Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we really need tox? #1890

Open
ulgens opened this issue Jan 21, 2025 · 4 comments
Open

Do we really need tox? #1890

ulgens opened this issue Jan 21, 2025 · 4 comments

Comments

@ulgens
Copy link
Contributor

ulgens commented Jan 21, 2025

While working with #1792, I realized that tox setup has some issues, and I tried to understand what is going on. Apparently, there is only one version of Python and Django that we test againist, and the tox config doesn't look like it does more than chaining tests and linting. tox is not needed for Django tests and the rest can be handled by pre-commit.

@adamzap
Copy link
Member

adamzap commented Jan 21, 2025

I think it'd be great if we could remove it.

I wonder if tox is useful for the pattern seen in these two commits where a new Python version is added to test against along side the old one before the old one is removed:

I'm looking forward to hear what others think!

@ulgens
Copy link
Contributor Author

ulgens commented Jan 21, 2025

@adamzap For those cases, wouldn't it be enough to test in on a new branch?

@adamzap
Copy link
Member

adamzap commented Jan 21, 2025

It should be. I personally think that would be ideal, but I don't know the current process.

@pauloxnet
Copy link
Member

I also don't think we need tox here.
Maybe we can open a draft PR to see all the required changes to get rid of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants