Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce config option to enable FSE on Windows #4598

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Conversation

doitsujin
Copy link
Owner

It sucks that Windows users have to choose between functioning VRR, HDR and present_wait (aka any sort of frame latency guarantees) on the one hand, or being able to alt+tab out of their games on the other, but there's not much we can really do as long as win32 vulkan WSI is stuck in d3d9 kinds of stone age.

Currently untested. Closes #4595.

@doitsujin doitsujin marked this pull request as ready for review January 9, 2025 17:13
@K0bin
Copy link
Collaborator

K0bin commented Jan 10, 2025

Also seems to be the cause of #4583 and probably the performance regression mentioned in #4572.

It would also make https://github.com/knock2one/dxvk_fse_github_actions redundant, which is also a good thing. Although we should perhaps mention it in the README, otherwise I assume those issues will keep coming.

@qinlili23333
Copy link
Contributor

Although we should perhaps mention it in the README, otherwise I assume those issues will keep coming.

I think we should update the wiki page for Windows. We should add more about FSE, VRR, HDR and other various common issues.

Maybe I can write a draft, but seems wiki git cannot accept pull requests. I'll try to write a comprehensive guide on my own site and it can be copied into wiki later if acceptable.

@K0bin
Copy link
Collaborator

K0bin commented Jan 10, 2025

Unfortunately it's not that common that people check the wiki but we could at least link it in response to issues then.

@doitsujin doitsujin merged commit efb9d44 into master Jan 10, 2025
8 checks passed
@doitsujin doitsujin deleted the fse-option branch January 10, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: Bring Fullscreen Exclusive back to Windows
3 participants