Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Blazor][MT] reduce synchronous calls from JS #54596

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Mar 18, 2024

  • update runtime type definitions
  • make invokeDotNetFromJS undefined in MT
    • which will throw and point user to use async alternative
  • make async
    • UpdateRootComponentsCore
    • updateWebAssemblyRootComponents
    • updateRootComponents
    • refreshRootComponents

Contributes to #54365 (comment)

- make invokeDotNetFromJS undefined in MT, which will throw and point to async
- make updateWebAssemblyRootComponents, updateRootComponents, refreshRootComponents, UpdateRootComponentsCore async
@pavelsavara pavelsavara added area-blazor Includes: Blazor, Razor Components feature-blazor-wasm-threading labels Mar 18, 2024
@pavelsavara pavelsavara added this to the 9.0.0 milestone Mar 18, 2024
@pavelsavara pavelsavara self-assigned this Mar 18, 2024
@pavelsavara pavelsavara requested a review from a team as a code owner March 18, 2024 14:04
Copy link
Contributor

Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no conflicting changes have occurred, please rerun validation before merging. You can do this by leaving an /azp run comment here (requires commit rights), or by simply closing and reopening.

@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Mar 26, 2024
@lewing
Copy link
Member

lewing commented Jan 22, 2025

should this be closed or updated?

@javiercn
Copy link
Member

My understanding is that this would be used for multi-threading, however, this introduces a behavior change, as the thread will be yielded before calling into .NET.

If this is not needed right now, I think we should park it.

@lewing lewing marked this pull request as draft January 24, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components feature-blazor-wasm-threading pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants