Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csproj completion in VS is broken for properties with limited set of values #11192

Closed
Youssef1313 opened this issue Dec 24, 2024 · 3 comments
Closed
Assignees
Labels
Priority:2 Work that is important, but not critical for the release triaged

Comments

@Youssef1313
Copy link
Member

I get completion for the property name, e.g: <Analys completes to AnalysisMode, but no completion for the value while there is a set of defined values already, including Recommended

image

@KalleOlaviNiemitalo
Copy link

The enumeration values in the schema are in lower case, but your screen shot shows a capitalised Re; might that difference stop Visual Studio from suggesting completions?

<xs:element name="AnalysisMode" substitutionGroup="msb:Property">
<xs:annotation>
<xs:documentation><!-- _locID_text="AnalysisMode" _locComment="" -->Customizes the set of rules that are enabled by default.</xs:documentation>
</xs:annotation>
<xs:simpleType>
<xs:restriction base="xs:string">
<xs:enumeration value="none" />
<xs:enumeration value="default" />
<xs:enumeration value="minimum" />
<xs:enumeration value="recommended" />
<xs:enumeration value="all" />
</xs:restriction>
</xs:simpleType>
</xs:element>

@maridematte maridematte added Priority:2 Work that is important, but not critical for the release triaged labels Jan 8, 2025
@JanProvaznik
Copy link
Member

JanProvaznik commented Jan 8, 2025

In MSBuild it is correct I think, it's debatable how VS completions should show up. And after playing with it is indeed a bit flaky (sometimes shows up sometimes not).

It seems to work for me most of the time.
Image

When I write Re <ctrl+space> (my autocomplete shortuct) it completes to recommended.

When I write a string the correct option is highlighted
Image

@Youssef1313
Copy link
Member Author

Thanks @JanProvaznik. I can no longer repro. I think this can be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:2 Work that is important, but not critical for the release triaged
Projects
None yet
Development

No branches or pull requests

4 participants