Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add glyph for deprecated members in intellisense dropdown #19583

Open
davidfowl opened this issue May 17, 2017 · 12 comments
Open

Add glyph for deprecated members in intellisense dropdown #19583

davidfowl opened this issue May 17, 2017 · 12 comments

Comments

@davidfowl
Copy link
Member

Today when you use a deprecated API the intellisense shows it as deprecated:

image

It would be nice if we showed that the member was deprecated via a glyph in the intellisense dropdown.

@Pilchie Pilchie added this to the Unknown milestone May 17, 2017
@Pilchie
Copy link
Member

Pilchie commented May 17, 2017

Tagging @kuhlenh and @markw-t. I wonder if we could re-use the warning glyph for when something isn't available in all heads here (potentially with a different glyph).

@kuhlenh
Copy link

kuhlenh commented May 17, 2017

@Pilchie @markw-t -- yes! Ideally, we can nicely group our intellisense glyph changes together (different glyph for the smart variable name suggestions).

@markw-t
Copy link

markw-t commented May 17, 2017

I seem to recall that something similar was proposed for shared project cases. Seems a good idea to make the icon show the deprecation too, I agree.

@mhutch
Copy link
Contributor

mhutch commented Jun 20, 2017

FWIW, in VSMac we designate these with a strikethrough in the completion list.

@davidfowl
Copy link
Member Author

Unknown milestone 😞

@CyrusNajmabadi
Copy link
Member

@markw-t Would it be costly to be able to add strikethrough capabilities to the completion presentation layer?

@Pilchie
Copy link
Member

Pilchie commented Jun 20, 2017

Didn't we used to have support for strikethrough or greying out to support "IntelliSense in Zone" for partial trust click once apps?

@genlu
Copy link
Member

genlu commented Dec 11, 2024

@sharwell I thought you implemented this recently, but apparently it's only for the classification but not in completionlist?

@CyrusNajmabadi
Copy link
Member

@olegtk is there some flag in the completion list api to strikethrough a completion item?

@JoeRobich
Copy link
Member

JoeRobich commented Jan 23, 2025

Maybe our VSCompletionItem can implement ITextFormattable and provide the strikethrough text decoration. haha strike that thought.

@olegtk
Copy link
Contributor

olegtk commented Jan 24, 2025

@CyrusNajmabadi not yet, tracked by https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2225286
But we do support strikethrough via ClassifiedTextRunStyle.Strikethrough starting with 17.14 Preview1 so I guess you can use it in completion tooltip already, but not in the completion item itself.

@CyrusNajmabadi
Copy link
Member

Ok. We'll wait on the completion work being done. If/when that happens, can you let us know so we can move on this? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants