What's with "Enumerable.Reverse()"?

[VladiStep]

The IEnumerable.Reverse() always does buffer the items, even for lists and arrays.
And also the buffering is not mentioned in the docs (e.g. https://learn.microsoft.com/en-us/dotnet/api/system.linq.enumerable.reverse).

There is an issue #15826, but it was 9 years ago, and I want to know if the opinion is the same.

[VladiStep]

Also, why "SourceLink" ("Go to implementation" option in Visual Studio) says that it uses Buffer<TSource> when the source code here says it uses just an array (TSource[]) ?

[VladiStep]

I almost forgot - it's .NET 6 ("C:\Program Files\dotnet\shared\Microsoft.NETCore.App\6.0.33\System.Linq.dll").
But it seems that the "release/6.0" branch has the same code for ReverseIterator as the "main".

[VladiStep]

#15826 (comment)

- you should document this
- nah it's fine people can find it by decompiling

😕

[huoyaoyuan]

Look carefully, the 6.0 version does use Buffer<TSource>: https://github.com/dotnet/runtime/blob/release/6.0/src/libraries/System.Linq/src/System/Linq/Reverse.cs#L57

[VladiStep]

Look carefully, the 6.0 version does use Buffer<TSource>: https://github.com/dotnet/runtime/blob/release/6.0/src/libraries/System.Linq/src/System/Linq/Reverse.cs#L57

Hm, I opened the branch and searched for ReverseIterator (using the search bar), but it seems it didn't open the right one.
Is the search bar broken?

[vcsjones]

Is the search bar broken?

If you mean the GitHub search, GitHub search is currently limited to the main branch.

[VladiStep]

@eiriktsarpalis, so the opinion is the same?

[eiriktsarpalis]

Not sure why I closed this, reopening.