[release/9.0-staging] Fix obtaining type handles of IDynamicInterfaceCastableImplementation #109909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Fixes #109496. We try to optimize away type handles (MethodTables) of types that are only needed due to metadata. Trying to grab type handle of such type throws. This fixes it by unconditionally generating type handles of IDynamicInterfaceCastableImplementation.
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
Open
3 tasks
jkotas
approved these changes
Nov 18, 2024
jeffschwMSFT
approved these changes
Nov 19, 2024
jeffschwMSFT
added
the
Servicing-consider
jeffschwMSFT
added
Servicing-approved
|
@MichalStrehovsky please take a look at the PR failures and merge when ready |
The logs expired weeks ago. The timing out leg doesn't run any of the affected code and cannot possibly be related. Going to add a bypass, but don't have rights to merge. |
|
/ba-g timeout in unrelated leg |
Never mind, looks like I do. For some reason I thought these branches are protected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #109875 to release/9.0-staging
/cc @MichalStrehovsky
Customer Impact
Hit by a 1st party in #109496. Users using CsWinRT might run into an issue where the compiler optimized away a part of a type that is necessary for execution.
Regression
Not a regression, this was broken since 7.0, but nobody was building WinUI apps with native AOT because CsWinRT didn't support it.
Testing
This requires a bit of bad luck to hit. The compiler will only optimize this away if the only thing that references the type in the entire app is a custom attribute. We now have a targeted test for this situation.
Risk
Low risk, this just suppresses an optimization.
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.