Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set font in tests #1428

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Set font in tests #1428

wants to merge 1 commit into from

Conversation

bynect
Copy link
Member

@bynect bynect commented Jan 1, 2025

This should fix #1404.

This is kind of an hack, but it should work for the fontconfig + pango problem.
Further testing is required

@codecov-commenter
Copy link

codecov-commenter commented Jan 1, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.28%. Comparing base (b7abe8f) to head (9a267f2).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1428      +/-   ##
==========================================
+ Coverage   65.19%   65.28%   +0.08%     
==========================================
  Files          50       50              
  Lines        8729     8737       +8     
  Branches     1034     1034              
==========================================
+ Hits         5691     5704      +13     
+ Misses       3038     3033       -5     
Flag Coverage Δ
unittests 65.28% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bynect bynect requested review from fwsmit and zappolowski January 1, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_calculate_dimensions_height_min test fails
2 participants