Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VertxHealthCheckEnricher: Unnecessary call to 'toString()' #3611

Closed
manusa opened this issue Jan 7, 2025 · 1 comment · Fixed by #3644
Closed

VertxHealthCheckEnricher: Unnecessary call to 'toString()' #3611

manusa opened this issue Jan 7, 2025 · 1 comment · Fixed by #3644
Assignees
@adhamahmad
Labels
first-timers-only Is this your first time contributing? This could be a good place to start! good first issue Good for newcomers
Milestone
1.19.0

Comments

@manusa
Copy link
Member

manusa commented Jan 7, 2025

Description

The class VertxHealthCheckEnricher presents the issue: Unnecessary call to 'toString()'.

The following line:

jkube/jkube-kit/jkube-kit-vertx/src/main/java/org/eclipse/jkube/vertx/enricher/VertxHealthCheckEnricher.java

Line 281 in a0a3369

config.getKey(), input.getClass(), input.toString()));

should be changed to:

                    config.getKey(), input.getClass(), input));

🔴 Before you start 🔴

👇 👇 👇 👇 👇 👇 👇 👇 👇 👇 👇 👇 👇 👇 👇 👇

Make sure you read the contributing guide first.

Pay special attention to the ECA agreement section and the requirement to sign-off your commit.

This is a first-timers-only issue. These issues are especially created for contributors who are contributing to the project for the first time.

If you have already contributed to this project in the past, please don't ask to be assigned one of these issues and look for good-first-issues or help-wanted issues instead in order to continue you contributor journey in the project.
@manusa manusa added first-timers-only Is this your first time contributing? This could be a good place to start! good first issue Good for newcomers labels Jan 7, 2025
@adhamahmad
Copy link
Contributor

Can i get assigned to this issue ?

adhamahmad added a commit to adhamahmad/jkube that referenced this issue Jan 27, 2025
@adhamahmad
fix: remove Unnecessary call to 'toString()' in VertxHealthCheckEnric…
e70f224 
…her.java (eclipse-jkube#3611)

Signed-off-by: Adham Ahmed Hussein Mahrous <[email protected]>
@adhamahmad adhamahmad mentioned this issue Jan 27, 2025
Merged
7 tasks
@manusa manusa added this to the 1.19.0 milestone Jan 28, 2025 — with automated-tasks
manusa pushed a commit that referenced this issue Jan 28, 2025
@adhamahmad
fix: remove Unnecessary call to 'toString()' in VertxHealthCheckEnric…
26a627a 
…her.java (#3611)

Signed-off-by: Adham Ahmed Hussein Mahrous <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adhamahmad adhamahmad

Labels
first-timers-only Is this your first time contributing? This could be a good place to start! good first issue Good for newcomers
Projects
None yet
Milestone
1.19.0
2 participants
@manusa @adhamahmad