Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pending component status #12001

Closed
Tracked by #11980
AdRiley opened this issue Jan 6, 2025 · 4 comments · Fixed by #12124
Closed
Tracked by #11980

Pending component status #12001

AdRiley opened this issue Jan 6, 2025 · 4 comments · Fixed by #12124
Assignees
Labels
-gui x-new-feature Type: new feature request

Comments

@AdRiley
Copy link
Member

AdRiley commented Jan 6, 2025

Reimplement #7435 but in GUI2

The IDE may receive the "Pending" status for nodes from the engine; it is sent in executionContext/expressionUpdates messages and stored in ComputedValueInfoRegistry inside the execution context.

In this task, this information should be propagated to view, and "pending" components should be displayed as greyed out (the original design I think will clash with selection)

@farmaazon
Copy link
Contributor

The edges coming from "pending" node should also be greyed out.

@farmaazon
Copy link
Contributor

The pending status of node already adds proper css class specified

and its defined:
--color-node-primary: var(--color-node-pending);

Why it's not visible? Perhaps we don't get Pending status from engine - to investigate.

@farmaazon farmaazon moved this from ❓New to 📤 Backlog in Issues Board Jan 15, 2025
@farmaazon farmaazon added the --bug Type: bug label Jan 15, 2025
@farmaazon
Copy link
Contributor

Refinement notes:

  • Good occasion to also change color of edges if source node is selected, if not already fixed.

@kazcw kazcw self-assigned this Jan 22, 2025
@kazcw kazcw moved this from 📤 Backlog to 🔧 Implementation in Issues Board Jan 23, 2025
@kazcw kazcw mentioned this issue Jan 23, 2025
5 tasks
@kazcw kazcw moved this from 🔧 Implementation to 👁️ Code review in Issues Board Jan 23, 2025
@enso-bot
Copy link

enso-bot bot commented Jan 23, 2025

Keziah Wesley reports a new STANDUP for today (2025-01-23):

Progress: Implemented component status edge colors, pending component animation. It should be finished by 2025-01-23.

Next Day: Next day I will be working on the #12001 task. Next task

@AdRiley AdRiley removed the --bug Type: bug label Jan 24, 2025
@mergify mergify bot closed this as completed in #12124 Jan 24, 2025
@mergify mergify bot closed this as completed in f281f84 Jan 24, 2025
@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-gui x-new-feature Type: new feature request
Projects
Status: 🟢 Accepted
Development

Successfully merging a pull request may close this issue.

3 participants