Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate non-boolean experimental flags in 3.6 #19141

Open
11 tasks
siyuanfoundation opened this issue Jan 7, 2025 · 3 comments
Open
11 tasks

Migrate non-boolean experimental flags in 3.6 #19141

siyuanfoundation opened this issue Jan 7, 2025 · 3 comments
Assignees

Comments

@siyuanfoundation
Copy link
Contributor

What would you like to be added?

For the 3.6 release, we would like to have the list of non-boolean --experimental flags migrated to flags without the --experimental prefix.

  • experimental-corrupt-check-time
  • experimental-compaction-batch-limit
  • experimental-watch-progress-notify-interval
  • experimental-warning-apply-duration
  • experimental-bootstrap-defrag-threshold-megabytes
  • experimental-warning-unary-request-duration
  • experimental-max-learners
  • experimental-snapshot-catch-up-entries
  • experimental-compaction-sleep-interval
  • experimental-downgrade-check-time
  • experimental-set-member-localaddr

In 3.6, we would like to have both the flags with and without the --experimental prefix working. experimentalNonBoolFlagMigrationMap should be used to achieve that. #19053 is an example (without the feature gate part).

Why is this needed?

flag clean up for release 3.6

@siyuanfoundation
Copy link
Contributor Author

@ahrtr @serathius Please double check the flag list and see if any flag needs to remain --experimental or missing any.

@siyuanfoundation
Copy link
Contributor Author

/cc @gangli113

@gangli113
Copy link

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants