-
Notifications
You must be signed in to change notification settings - Fork 644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve BuildXConfiguration isBuildX method #1802
Comments
Here's some context I have as to other use cases for BuildKit/BuildX outside the current use cases directly supported by this plugin: I recently encountered another use case for Current Behavior of PluginBuilding a Dockerfile using Issues with Current Workaround
Thoughts on a FixIssue #1267 seemed to originally request a way to just explicitly enable BuildKit/BuildX in the plugin configuration, but it was closed when just the multi-platform build feature was implemented, without addressing other use cases, such as those mentioned here, or elsewhere in that issue. It seems there are two relatively straightforward ways this option could be implemented: Using the docker REST API query parameter that someone recently mentioned in a new comment added after #1267 was closed (Comment Link), or allowing the existing BuildX builder that calls out to the CLI to be used without specifying any It might also be worth considering enabling BuildKit by default, to mirror the Docker CLI's current behavior, while providing an option to revert back to the old classic builder for those who need it, considering that Docker has deprecated the classic builder. |
We had modified BuildXConfiguration's
isBuildX
method in #1799 but as per #1799 (comment) there might be more use cases for which we need to enable buildkit.Originally posted by @rohanKanojia in #1799 (comment)
The text was updated successfully, but these errors were encountered: