Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support equivalent of [merge] comment in pipelines #301

Open
rawlingsj opened this issue Aug 25, 2017 · 0 comments
Open

support equivalent of [merge] comment in pipelines #301

rawlingsj opened this issue Aug 25, 2017 · 0 comments

Comments

@rawlingsj
Copy link
Contributor

fabric8's own CI jobs use the github pull request plugin and a [merge] on PRs to merge changes providing tests pass. This doesn't work with Jenkins Pipelines so it means we are still reliant on the old CI infra.

I wonder if instead of the flow.addMergeCommentToPullRequest(id, project) steps we have in the library we could have a new function that checks the PR has had CI checks passed and then performs a merge?

https://developer.github.com/v3/pulls/#merge-a-pull-request-merge-button
@rawlingsj rawlingsj changed the title support [merge] in pipelines support equivalent of [merge] comment in pipelines Aug 25, 2017
rawlingsj added a commit to rawlingsj/fabric8-pipeline-library that referenced this issue Aug 25, 2017
@rawlingsj
add function to check PR CI checks have passed before auto merge fabr…
484c93b 
…ic8io#301
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rawlingsj