From 8a276274e9f0c4d66fe5d2f6e0b5fff70b99cf91 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Michal=20Kvasnic=CC=8Ca=CC=81k?=
 <michal.kvasnicak@gmail.com>
Date: Wed, 8 Jan 2025 11:47:13 +0100
Subject: [PATCH] refactor: remove signer dependency from useFrameApp hook

---
 .../app/components/frame-app-debugger.tsx     | 15 +++++-
 packages/render/src/use-frame-app.ts          | 49 ++++---------------
 2 files changed, 23 insertions(+), 41 deletions(-)

diff --git a/packages/debugger/app/components/frame-app-debugger.tsx b/packages/debugger/app/components/frame-app-debugger.tsx
index cf0cbe2c..6f710b04 100644
--- a/packages/debugger/app/components/frame-app-debugger.tsx
+++ b/packages/debugger/app/components/frame-app-debugger.tsx
@@ -71,6 +71,19 @@ export function FrameAppDebugger({
   const config = useConfig();
   const farcasterSignerRef = useRef(farcasterSigner);
   farcasterSignerRef.current = farcasterSigner;
+
+  const userContext = useRef<{ fid: number }>({ fid: -1 });
+
+  if (
+    (farcasterSigner.signer?.status === "approved" ||
+      farcasterSigner.signer?.status === "impersonating") &&
+    userContext.current.fid !== farcasterSigner.signer.fid
+  ) {
+    userContext.current = {
+      fid: farcasterSigner.signer.fid,
+    };
+  }
+
   const frameAppNotificationManager = useFrameAppNotificationsManager({
     farcasterSigner,
     context,
@@ -154,7 +167,7 @@ export function FrameAppDebugger({
             embed: "",
             cast: fallbackFrameContext.castId,
           },
-    farcasterSigner,
+    user: userContext.current,
     provider,
     proxyUrl: "/frames",
     addFrameRequestsCache,
diff --git a/packages/render/src/use-frame-app.ts b/packages/render/src/use-frame-app.ts
index f78d1010..a5e7c7ca 100644
--- a/packages/render/src/use-frame-app.ts
+++ b/packages/render/src/use-frame-app.ts
@@ -3,8 +3,6 @@ import type { FrameHost, HostEndpoint, Context } from "@farcaster/frame-host";
 import { AddFrame } from "@farcaster/frame-host";
 import { useMemo } from "react";
 import { useFreshRef } from "./hooks/use-fresh-ref";
-import type { FarcasterSignerState } from "./farcaster";
-import type { FarcasterSigner } from "./identity/farcaster";
 import type {
   EthProvider,
   FrameClientConfig,
@@ -126,6 +124,12 @@ export type UseFrameAppOptions = {
    * @defaultValue launcher context
    */
   location?: Context.LocationContext;
+  /**
+   * Information about the user who manipulates with the frame.
+   *
+   * Value should be memoized otherwise it will cause unnecessary re-renders.
+   */
+  user: Context.UserContext;
   /**
    * Either:
    *
@@ -145,27 +149,6 @@ export type UseFrameAppOptions = {
    * Frame proxyUrl used to fetch the frame parse result.
    */
   proxyUrl: string;
-  /**
-   * Farcaster signer state. Must be approved or impersonated.
-   *
-   * @example
-   * ```ts
-   * import { useFarcasterSigner } from '@frames.js/render/identity/farcaster';
-   *
-   * function Component() {
-   *  const farcasterSigner = useFarcasterSigner({
-   *   // ...
-   *  });
-   *  const frameApp = useFrameApp({
-   *   farcasterSigner,
-   *   // ...
-   *  });
-   *
-   *  //...
-   * }
-   * ```
-   */
-  farcasterSigner: FarcasterSignerState<FarcasterSigner | null>;
   /**
    * Called when app calls `ready` method.
    */
@@ -251,7 +234,7 @@ export function useFrameApp({
   provider,
   client,
   location = defaultLocation,
-  farcasterSigner,
+  user,
   source,
   fetchFn,
   proxyUrl,
@@ -281,7 +264,6 @@ export function useFrameApp({
     onEIP6963RequestProviderRequested
   );
   const onSignInRef = useFreshRef(onSignIn);
-  const farcasterSignerRef = useFreshRef(farcasterSigner);
   const onAddFrameRequestedRef = useFreshRef(onAddFrameRequested);
   const addFrameRequestsCacheRef = useFreshRef(addFrameRequestsCache);
   const clientResolutionState = useResolveClient({ client });
@@ -315,19 +297,6 @@ export function useFrameApp({
       };
     }
 
-    if (
-      farcasterSignerRef.current.signer?.status !== "approved" &&
-      farcasterSignerRef.current.signer?.status !== "impersonating"
-    ) {
-      return {
-        status: "error",
-        error: new Error(
-          "Farcaster signer must be either approved or impersonating"
-        ),
-      };
-    }
-
-    const signer = farcasterSignerRef.current.signer;
     const resolvedClient = clientResolutionState.client;
 
     switch (frameResolutionState.status) {
@@ -405,7 +374,7 @@ export function useFrameApp({
             context: {
               client: resolvedClient,
               location: locationRef.current,
-              user: { fid: signer.fid },
+              user,
             },
             async ethProviderRequest(parameters) {
               // @ts-expect-error -- type mismatch
@@ -466,7 +435,6 @@ export function useFrameApp({
     }
   }, [
     clientResolutionState,
-    farcasterSignerRef,
     frameResolutionState,
     locationRef,
     logDebug,
@@ -480,5 +448,6 @@ export function useFrameApp({
     onViewProfileRef,
     onEIP6963RequestProviderRequestedRef,
     onSignInRef,
+    user,
   ]);
 }