Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Remove checked-in dist folder for dataobj-explorer #15926

Open
3 tasks
cyriltovena opened this issue Jan 23, 2025 · 0 comments
Open
3 tasks

build: Remove checked-in dist folder for dataobj-explorer #15926

cyriltovena opened this issue Jan 23, 2025 · 0 comments

Comments

@cyriltovena
Copy link
Contributor

Problem

The dist folder for dataobj-explorer is currently checked into git, creating maintenance issues:

  • Code and dist can become out of sync
  • Changes require manual rebuilds and commits
  • Prone to human error

While this supports projects vendoring Loki via go mod vendor, we don't need the dist folder in Loki itself since assets are built in the Dockerfile.

Proposed Solution

Investigate using go:generate to:

  • Remove dist folder from git
  • Maintain compatibility with vendored projects
  • Generate assets during build

Implementation Options

-Use go:generate to trigger asset building

  • Add build step in go.mod/tools.go
  • Update documentation for projects vendoring Loki

Immediate Improvements

Until fully resolved:

  • Add CI check to verify dist matches source
  • Create make target to validate sync status
  • Add documentation about manual rebuild requirements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant