Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up formatting of generated files #17

Open
edgrosvenor opened this issue Feb 17, 2020 · 1 comment
Open

Clean up formatting of generated files #17

edgrosvenor opened this issue Feb 17, 2020 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@edgrosvenor
Copy link
Collaborator

I'm not sure what the best approach is here. I like using Blade templates for the stubs because even the newbiest of Laravel newbies can edit them confidently. But the output is a white space nightmare. So let's come up with a frictionless way of fixing the format of the PHP files this package generates. Whether we do it before we write the contents to the file or after the files are created. Totally open to suggestions here.
@edgrosvenor edgrosvenor added the help wanted Extra attention is needed label Feb 17, 2020
@edgrosvenor
Copy link
Collaborator Author

This looks like a good solution: https://github.com/matt-allan/laravel-code-style

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@edgrosvenor