Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go < 1.9: Compatibility issue #56

Open
alanjds opened this issue Aug 21, 2018 · 2 comments
Open

Go < 1.9: Compatibility issue #56

alanjds opened this issue Aug 21, 2018 · 2 comments
Labels
imported Imported from google/grumpy

Comments

@alanjds
Copy link

alanjds commented Aug 21, 2018

google#386 opened by @corona10 on Nov 8, 2017

We met some issues related to Go version.
For example, Go 1.9 moved to C99 float division.
As the result, we need to change unit test codes. (See google#384)
However, this approach is not cool enough to support old Go version.
So, we need to update unit tests codes to support Go < 1.9 also Go 1.9

@alanjds
Copy link
Author

alanjds commented Aug 21, 2018

Comment by hero0926
Thursday Mar 08, 2018 at 00:22 GMT


I tried to use it Go 1.8 and 1.7 and some test were failed. Which go versions are compatible?

@alanjds
Copy link
Author

alanjds commented Aug 21, 2018

Comment by corona10
Thursday Mar 08, 2018 at 04:13 GMT


@hero0926 For test. Use 1.9 :)

@alanjds alanjds added the imported Imported from google/grumpy label Aug 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
imported Imported from google/grumpy
Projects
None yet
Development

No branches or pull requests

1 participant