Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PATCH operations #219

Open
averche opened this issue Jul 28, 2023 · 1 comment
Open

Add support for PATCH operations #219

averche opened this issue Jul 28, 2023 · 1 comment

Comments

@averche
Copy link
Collaborator

averche commented Jul 28, 2023

Describe the feature request or question

We should add support for PATCH operations, which are currently missing from the two generated libraries and the underlying openapi.json.

Additional information

As far as I know, PATCH is currently used by KvV2 and a couple PKI endpoints (1, 2). We do not currently account for it in openapi.go.

We could also consider adding something like JSONMergePatch, but if the problem can be solved at the OpenAPI level, I don't think it's necessary.

@maxb
Copy link
Contributor

maxb commented Aug 6, 2023

This ties in with #195 as using PATCH introduces new ways in which omitting a field, vs. including it set to a zero value, has meaning.

Technically JSON Merge Patch also assigns meaning to including a field explicitly set to null, though it's an open question whether this would ever be useful in the context of Vault configuration endpoints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants