Injector not disabled when "injector.enabled" is set to "false" in values.yaml

[Hesham-14]

Describe the bug
I’m using the HashiCorp Vault Helm chart with ArgoCD and trying to disable the injector by setting injector.enabled: false in my values.yaml. However,the Vault injector deployment is not being disabled and remains running.

To Reproduce
Steps to reproduce the behavior:

1. Deploy the HashiCorp Vault Helm chart using the following values.yaml:

# ArgoCD App Name
hashicorp-vault:
  injector:
    enabled: false

2. Sync the Helm release using ArgoCD.

Expected behavior
The injector deployment should be disabled and removed when injector.enabled is set to false.

Actual Behavior
The injector deployment remains live and is not disabled.

$ kubectl get deployment -n <namespace> | grep vault-agent-injector
hashicorp-vault-agent-injector   1/1     1            1           89m

Environment

• Kubernetes version: 1.31.4
• ArgoCD version: 2.12.6
• vault-helm version: 0.29.1

Chart values:

hashicorp-vault:
  injector:
    enabled: false

Additional context

• The injector-deployment.yaml template uses the vault.injectorEnabled helper function, which looks for .Values.injector.enabled at the root level. However, my values.yaml nests injector.enabled under hashicorp-vault (required for ArgoCD App-of-Apps compatibility).
• Here's the relevant part of the helper function:

{{- define "vault.injectorEnabled" -}}
{{- $_ := set . "injectorEnabled" (or
  (eq (.Values.injector.enabled | toString) "true")
  (and (eq (.Values.injector.enabled | toString) "-") (eq (.Values.global.enabled | toString) "true"))) -}}
{{- end -}}

• I believe the issue is that the helper function does not account for the hashicorp-vault prefix in the values.yaml.