Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flip the default value of lukko flag in hackage-security #10724

Open
Mikolaj opened this issue Jan 7, 2025 · 2 comments
Open

Flip the default value of lukko flag in hackage-security #10724

Mikolaj opened this issue Jan 7, 2025 · 2 comments

Comments

@Mikolaj
Copy link
Member

Mikolaj commented Jan 7, 2025

Describe the feature request

Let's disable lukko by default on cabal master branch and if it works well, lets release cabal with this change and if it works well, let's make the flag flip also in hackage-security. Lukko is a workaround for a problem in base and it's hoped that it's not needed any more (and so it's not maintained as vigorously as when it was really needed).

Since cabal is the main (only?) user of https://github.com/haskell/hackage-security, let's discuss here (and not in hackage-security bug tracker) this course of action, initially proposed by @Bodigrim in haskellari/lukko#39 (comment). The ticket also provides the context for this change.

One of related cabal tickets suggests some users work with the proposed setup (no lukko) successfully for many years now: #6657

@fgaz
Copy link
Member

fgaz commented Jan 16, 2025

Lukko is a workaround for a problem in base

Since it's dependent on base version we could change it to manual: False default: False. This way it will automatically turn on for old base versions (because of this bound).

Or if all problematic base versions are outside of our support window we can just (gradually, setting it to False first) drop it.

@Mikolaj
Copy link
Member Author

Mikolaj commented Jan 16, 2025

We've agreed on the outline of the deprecation process, so with some luck it's a one-line change, but it requires grepping through the code to confirm the flag is not used in surprising ways and really not documented anywhere and, generally, some sanity checks and "what could go wrong" consideration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants