Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying document via an option #58

Open
Thristhart opened this issue Aug 10, 2015 · 0 comments
Open

Allow specifying document via an option #58

Thristhart opened this issue Aug 10, 2015 · 0 comments

Comments

@Thristhart
Copy link

We use Flipsnap in an application that involves iframes. Unfortunately, mouse/touch events don't work properly in our use case, because the document that Flipsnap uses is different than the contentDocument of the iframe. We could fix that by passing a reference to the contentDocument as an option, and Flipsnap could use that instead of the top level document. I believe there are only a couple instances that matter -- in _touchStart and _touchEnd, when the eventListeners are added.

I'm posting this as an issue rather than a pull request because I want to see if you agree that this is the best way to solve the problem, but if you like I can submit a pull request as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant