This repository has been archived by the owner on Mar 18, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4
/
Copy pathauthorizations_test.go
479 lines (397 loc) · 13.8 KB
/
authorizations_test.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
// This Source Code Form is subject to the terms of the Mozilla Public
// License, version 2.0. If a copy of the MPL was not distributed with this
// file, You can obtain one at http://mozilla.org/MPL/2.0/.
package oauth2
import (
"bytes"
"encoding/json"
"net/http"
"net/http/httptest"
"net/url"
"strings"
"testing"
"time"
"github.com/hooklift/oauth2/providers/test"
"github.com/hooklift/oauth2/types"
)
func setupTest() config {
authzForm := `
<html>
<body>
{{if .Errors}}
<div id="errors">
<ul>
{{range .Errors}}
<li>{{.Code}}: {{.Description}}</li>
{{end}}
</ul>
</div>
{{else}}
<div id="client">
<h2>{{.Client.Name}}</h2>
<h3>{{.Client.Description}}</h3>
<a href="{{.Client.HomepageURL}}">
<figure><img src="{{.Client.LogoURL}}"/></figure>
</a>
</div>
<div id="scopes">
<ul>
{{range .Scopes}}
<li>{{.ID}}: {{.Description}}</li>
{{end}}
</ul>
</div>
<form>
<input type="hidden" name="client_id" value="{{.Client.ID}}"/>
<input type="hidden" name="response_type" value="{{.GrantType}}"/>
<input type="hidden" name="redirect_uri" value="{{.Client.RedirectURL}}"/>
<input type="hidden" name="scope" value="{{.Scopes.Encode}}"/>
<input type="hidden" name="state" value="{{.State}}"/>
</form>
{{end}}
</body>
</html>
`
cfg := config{
tokenEndpoint: "/oauth2/tokens",
authzEndpoint: "/oauth2/authzs",
stsMaxAge: time.Duration(0) * time.Second,
authzExpiration: time.Duration(1) * time.Minute,
tokenExpiration: time.Duration(10) * time.Minute,
}
SetAuthzForm(authzForm)(&cfg)
SetLoginURL("https://api.hooklift.io/accounts/login", "redirect_to")(&cfg)
return cfg
}
// getTestAuthzCode returns authorization tokens for access tokens issuing tests
func getTestAuthzCode(t *testing.T) (config, string) {
cfg := setupTest()
provider := test.NewProvider(true)
cfg.provider = provider
state := "state-test"
scopes := "read write identity"
grantType := "code"
values := url.Values{
"client_id": {provider.Client.ID},
"response_type": {grantType},
"state": {state},
"redirect_uri": {provider.Client.RedirectURL.String()},
"scope": {scopes},
}
// http://tools.ietf.org/html/rfc6749#section-4.1.1
queryStr := values.Encode()
req, err := http.NewRequest("GET",
"https://example.com/oauth2/authzs?"+queryStr, nil)
ok(t, err)
w := httptest.NewRecorder()
CreateGrant(w, req, cfg)
equals(t, http.StatusOK, w.Code)
body := w.Body.String()
stringz := []string{
"client_id",
"redirect_uri",
"response_type",
"state",
"scope",
"code",
"read write identity",
"state-test",
}
for _, s := range stringz {
assert(t, strings.Contains(body, s), "Does not look like we got an authorization form: '%s' was not found in %v", s, body)
}
// Sending post to acquire authorization token
buffer := bytes.NewBufferString(queryStr)
req, err = http.NewRequest("POST", "https://example.com/oauth2/authzs", buffer)
ok(t, err)
req.Header.Set("Content-type", "application/x-www-form-urlencoded")
w = httptest.NewRecorder()
CreateGrant(w, req, cfg)
// Tests http://tools.ietf.org/html/rfc6749#section-4.1.2
equals(t, http.StatusFound, w.Code)
redirectTo := w.Header().Get("Location")
u, err := url.Parse(redirectTo)
ok(t, err)
authzCode := u.Query().Get("code")
assert(t, authzCode != "", "It looks like the authorization code came back empty: %s", authzCode)
// makes sure the same state parameter value received to acquire
// the authorization grant is send back when delivering the access token.
equals(t, state, u.Query().Get("state"))
return cfg, authzCode
}
// TestAuthorizationGrant tests a happy web authorization flow in accordance with
// http://tools.ietf.org/html/rfc6749#section-4.1
func TestAuthorizationGrant(t *testing.T) {
getTestAuthzCode(t)
}
// TestLoginRedirect tests that logging in is required for a resource owner to
// grant any authorization codes to clients.
func TestLoginRedirect(t *testing.T) {
cfg := setupTest()
provider := test.NewProvider(false)
cfg.provider = provider
state := "state-test"
scopes := "read write identity"
grantType := "code"
clientID := provider.Client.ID
redirectURL := provider.Client.RedirectURL.String()
values := url.Values{
"client_id": {clientID},
"response_type": {grantType},
"state": {state},
"redirect_uri": {redirectURL},
"scope": {scopes},
}
// http://tools.ietf.org/html/rfc6749#section-4.1.1
queryStr := values.Encode()
authzURL := "https://example.com/oauth2/authzs?" + queryStr
req, err := http.NewRequest("GET", authzURL, nil)
ok(t, err)
w := httptest.NewRecorder()
CreateGrant(w, req, cfg)
equals(t, http.StatusFound, w.Code)
loginURL := cfg.loginURL.url
query := loginURL.Query()
query.Set(cfg.loginURL.redirectParam, authzURL)
loginURL.RawQuery = query.Encode()
equals(t, loginURL.String(), w.Header().Get("Location"))
}
// TestImplicitGrant tests a happy implicit flow
func TestImplicitGrant(t *testing.T) {
cfg := setupTest()
provider := test.NewProvider(true)
cfg.provider = provider
state := "state-test"
scopes := "read write identity"
grantType := "token"
clientID := provider.Client.ID
redirectURL := provider.Client.RedirectURL.String()
values := url.Values{
"client_id": {clientID},
"response_type": {grantType},
"state": {state},
"redirect_uri": {redirectURL},
"scope": {scopes},
}
// http://tools.ietf.org/html/rfc6749#section-4.2.1
queryStr := values.Encode()
authzURL := "https://example.com/oauth2/authzs?" + queryStr
req, err := http.NewRequest("GET", authzURL, nil)
ok(t, err)
w := httptest.NewRecorder()
CreateGrant(w, req, cfg)
body := w.Body.String()
stringz := []string{
"client_id",
"redirect_uri",
"response_type",
"state",
"scope",
"token",
"read write identity",
"state-test",
}
for _, s := range stringz {
assert(t, strings.Contains(body, s), "Does not look like we got an authorization form: '%s' was not found in %v", s, body)
}
// Sending post to acquire authorization token
buffer := bytes.NewBufferString(queryStr)
req, err = http.NewRequest("POST", "https://example.com/oauth2/authzs", buffer)
ok(t, err)
req.Header.Set("Content-type", "application/x-www-form-urlencoded")
w = httptest.NewRecorder()
CreateGrant(w, req, cfg)
// Tests http://tools.ietf.org/html/rfc6749#section-4.2.2
equals(t, http.StatusFound, w.Code)
redirectTo := w.Header().Get("Location")
u, err := url.Parse(redirectTo)
ok(t, err)
fragment, err := url.ParseQuery(strings.TrimPrefix(u.Fragment, "#"))
ok(t, err)
accessToken := fragment.Get("access_token")
assert(t, accessToken != "", "It looks like the authorization code came back empty: ->%s<-", accessToken)
equals(t, state, fragment.Get("state"))
equals(t, "600", fragment.Get("expires_in"))
equals(t, scopes, fragment.Get("scope"))
equals(t, "bearer", fragment.Get("token_type"))
// Implict flow should not emit refresh tokens
refreshToken := fragment.Get("refresh_token")
equals(t, "", refreshToken)
}
// TestReplayAttackProtection tests that the authorization grant can be used
// only once.
func TestReplayAttackProtection(t *testing.T) {
cfg, authzCode := getTestAuthzCode(t)
req := AuthzGrantTokenRequestTest(t, "authorization_code", authzCode)
req.SetBasicAuth("test_client_id", "test_client_id")
w := httptest.NewRecorder()
IssueToken(w, req, cfg)
token := types.Token{}
err := json.Unmarshal(w.Body.Bytes(), &token)
ok(t, err)
equals(t, "bearer", token.Type)
equals(t, "600", token.ExpiresIn)
w2 := httptest.NewRecorder()
IssueToken(w2, req, cfg)
// http://tools.ietf.org/html/rfc6749#section-4.1.4
authzErr := types.AuthzError{}
//log.Printf("%s", w2.Body.String())
err = json.Unmarshal(w2.Body.Bytes(), &authzErr)
ok(t, err)
equals(t, "invalid_grant", authzErr.Code)
equals(t, "Grant code was revoked, expired or already used.", authzErr.Description)
}
// TestRedirectURLMatch makes sure redirect_uri for requesting an authorization
// grant is the same as the redirect_uri provided to get the correspondent access token.
// This is intended to mitigate the risk of account hijacking by leaking
// authorization codes.
func TestRedirectURLMatch(t *testing.T) {
cfg := setupTest()
provider := test.NewProvider(true)
cfg.provider = provider
state := "state-test"
scopes := "read write identity"
grantType := "code"
values := url.Values{
"client_id": {provider.Client.ID},
"response_type": {grantType},
"state": {state},
"redirect_uri": {provider.Client.RedirectURL.String()},
"scope": {scopes},
}
// http://tools.ietf.org/html/rfc6749#section-4.1.1
queryStr := values.Encode()
req, err := http.NewRequest("GET",
"https://example.com/oauth2/authzs?"+queryStr, nil)
ok(t, err)
w := httptest.NewRecorder()
CreateGrant(w, req, cfg)
equals(t, http.StatusOK, w.Code)
// Sending post to acquire authorization token
values.Set("redirect_uri", "https://attacker.com/callback")
queryStr2 := values.Encode()
buffer := bytes.NewBufferString(queryStr2)
req, err = http.NewRequest("POST", "https://example.com/oauth2/authzs", buffer)
ok(t, err)
req.Header.Set("Content-type", "application/x-www-form-urlencoded")
w2 := httptest.NewRecorder()
CreateGrant(w2, req, cfg)
body := w2.Body.String()
assert(t, strings.Contains(body, "access_denied"), "access_denied was expected as response")
assert(t, strings.Contains(body, "3rd-party client app provided a redirect_uri that does not match the URI registered for this client in our database."), "unexpected error description.")
}
// TestAccessTokenOwnership makes sure a token belongs to the client_id making
// the request with it. This mitigates account hijacking as well.
func TestAccessTokenOwnership(t *testing.T) {
}
// TestAccessTokenExpiration makes sure that access tokens are actually expired.
func TestAccessTokenExpiration(t *testing.T) {
}
// TestScopeIsRequired makes sure it requires clients to provide access scopes when
// getting authorization codes.
func TestScopeIsRequired(t *testing.T) {
cfg := setupTest()
provider := test.NewProvider(true)
cfg.provider = provider
state := "my-state"
grantType := "code"
values := url.Values{
"client_id": {provider.Client.ID},
"response_type": {grantType},
"state": {state},
"redirect_uri": {provider.Client.RedirectURL.String()},
}
// http://tools.ietf.org/html/rfc6749#section-4.1.1
queryStr := values.Encode()
req, err := http.NewRequest("GET",
"https://example.com/oauth2/authzs?"+queryStr, nil)
ok(t, err)
w := httptest.NewRecorder()
CreateGrant(w, req, cfg)
equals(t, http.StatusFound, w.Code)
u, err := url.Parse(w.Header().Get("Location"))
ok(t, err)
equals(t, "invalid_request", u.Query().Get("error"))
equals(t, "scope parameter is required by this authorization server.", u.Query().Get("error_description"))
}
// TestStateIsRequired makes sure it requires clients to provide a state when
// getting authorization codes.
func TestStateIsRequired(t *testing.T) {
cfg := setupTest()
provider := test.NewProvider(true)
cfg.provider = provider
scopes := "read write identity"
grantType := "code"
values := url.Values{
"client_id": {provider.Client.ID},
"response_type": {grantType},
"redirect_uri": {provider.Client.RedirectURL.String()},
"scope": {scopes},
}
// http://tools.ietf.org/html/rfc6749#section-4.1.1
queryStr := values.Encode()
req, err := http.NewRequest("GET",
"https://example.com/oauth2/authzs?"+queryStr, nil)
ok(t, err)
w := httptest.NewRecorder()
CreateGrant(w, req, cfg)
equals(t, http.StatusFound, w.Code)
u, err := url.Parse(w.Header().Get("Location"))
ok(t, err)
equals(t, "invalid_request", u.Query().Get("error"))
equals(t, "state parameter is required by this authorization server.", u.Query().Get("error_description"))
}
// TestSecurityHeaders makes sure security headers are sent along the authorization form.
func TestSecurityHeaders(t *testing.T) {
cfg := setupTest()
provider := test.NewProvider(true)
cfg.provider = provider
state := "mystate"
scopes := "read write identity"
grantType := "code"
values := url.Values{
"client_id": {provider.Client.ID},
"state": {state},
"response_type": {grantType},
"redirect_uri": {provider.Client.RedirectURL.String()},
"scope": {scopes},
}
// http://tools.ietf.org/html/rfc6749#section-4.1.1
queryStr := values.Encode()
req, err := http.NewRequest("GET",
"https://example.com/oauth2/authzs?"+queryStr, nil)
ok(t, err)
w := httptest.NewRecorder()
CreateGrant(w, req, cfg)
//log.Printf("%+v", w.HeaderMap)
equals(t, "max-age=0", w.Header().Get("Strict-Transport-Security"))
equals(t, "1; mode=block", w.Header().Get("X-XSS-Protection"))
equals(t, "nosniff", w.Header().Get("X-Content-Type-Options"))
equals(t, "SAMEORIGIN", w.Header().Get("X-Frame-Options"))
}
// TestRedirectURIScheme makes sure clients provide redirect URLs that use TLS
func TestRedirectURIScheme(t *testing.T) {
cfg := setupTest()
provider := test.NewProvider(true)
cfg.provider = provider
state := "state-test"
scopes := "read write identity"
grantType := "code"
values := url.Values{
"client_id": {provider.Client.ID},
"response_type": {grantType},
"state": {state},
"redirect_uri": {"http://attacker.com/callback"},
"scope": {scopes},
}
// http://tools.ietf.org/html/rfc6749#section-4.1.1
queryStr := values.Encode()
req, err := http.NewRequest("GET",
"https://example.com/oauth2/authzs?"+queryStr, nil)
ok(t, err)
w := httptest.NewRecorder()
CreateGrant(w, req, cfg)
body := w.Body.String()
assert(t, strings.Contains(body, "access_denied") == true, "access-denied was not found in response body")
assert(t, strings.Contains(body, "3rd-party client app provided an invalid redirect_uri. It does not comply with http://tools.ietf.org/html/rfc3986#section-4.3 or does not use HTTPS") == true, "error description does not match.")
}