Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Padding option should allow zero values #21

Open
sevrai opened this issue Nov 6, 2024 · 0 comments · May be fixed by #22
Open

Padding option should allow zero values #21

sevrai opened this issue Nov 6, 2024 · 0 comments · May be fixed by #22

Comments

@sevrai
Copy link

sevrai commented Nov 6, 2024

Hello,

I noticed padding parameters omit zero values when I use generateImageUrl method.
The resulting images are not the same :

/insecure/pd:50:0:50:0/bg:FFFF00/rs:fit:500/plain/path /insecure/pd:50::50/bg:FFFF00/rs:fit:500/plain/path
image image

The option object that can be used for reproduction is the following:

const options = {
  padding: {
    left: 0
    top: 50
    right: 0
    bottom: 50
  }
}

I'll create a PR with the fix 🙂

@sevrai sevrai linked a pull request Nov 6, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant