Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to rethink the setup for testing #10

Open
jaredpar opened this issue May 16, 2017 · 0 comments
Open

Need to rethink the setup for testing #10

jaredpar opened this issue May 16, 2017 · 0 comments

Comments

@jaredpar
Copy link
Owner

The design of EditorUtils NuGet packaging and testing strategy is 5+ years old. It was done at a time when I had less understanding of binding redirects, assembly resolution and the GAC. As a result I missed a couple of important scenarios but was constantly saved by the fact that all of the editor assemblies were in the GAC. Now that VS 2017 is out and have removed all of the GAC entries these flaws are showing now and causing me to rethink the setup.

The testing strategy was designed around the idea that a developer could:

  • Add a reference to EditorUtils VS version X
  • Use binding redirects to test against VS version X, X +1, etc ...

This meant at build time you could control the VS version to test against by simply changing the binding redirects. In general it would essentially work like the following:

  • EditorUtils compiled against 10.0.0.0
  • Test directory has editor assemblies version 10.0.0.0
  • Binding redirect moves 10.0.0.0 -> 14.0.0.0
  • At runtime
    • None of the editor assemblies in test directory match due to the redirect.
    • The assemblies do exist in the GAC and win

That runtime behavior really falls apart in VS 2017 because there is no GAC. It's making me question the overall strategy here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant