Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Models in ListField are not validated when calling .validate() #136

Open
paulopaixaoamaral opened this issue Apr 28, 2020 · 0 comments
Open

Comments

@paulopaixaoamaral
Copy link
Member

If we have a ListField with items of type models.Base, for example:

from jsonmodels import models, fields

class Cat(models.Base):
    name = fields.StringField(required=True)

class Person(models.Base):
    pets = fields.ListField([Cat])

And we call .validate() on the model:

person = Person(pets=[Cat()])
person.validate()

Then nothing will happen, but if we call .to_struct() on the model:

person = Person(pets=[Cat()])
person.to_struct()

Then a ValidationError is raised:

>>> jsonmodels.errors.ValidationError: ("Error for field 'name'.", ValidationError('Field is required!'))

Is this working as intended or should the list call .validate() on its items if the item is an instance of a model?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant