Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Issue with createNavs and removeNavs Functions by Correcting .some() Method Usage #241

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DineshNehra29
Copy link

@DineshNehra29 DineshNehra29 commented Dec 17, 2024

Fixes #240
This pull request addresses the issue where the createNavs and removeNavs functions in the navigation system were not executing properly due to incorrect usage of the .some() method.

Changes Made:

Corrected .some() Method Usage:

Removed the .length property from the .some() method in the createNavs and removeNavs functions as .some() returns a boolean and not an array.

…e() Method Usage

This pull request addresses the issue where the createNavs and removeNavs functions in the navigation system were not executing properly due to incorrect usage of the .some() method.

Changes Made:

Corrected .some() Method Usage:

Removed the .length property from the .some() method in the createNavs and removeNavs functions as .some() returns a boolean and not an array.
@DineshNehra29
Copy link
Author

This is my first pull request, I would greatly appreciate any guidance or feedback you can provide. Your insights will help me improve and contribute more effectively in the future.

@DineshNehra29 DineshNehra29 changed the title Fix Issue with createNavs and removeNavs Functions by Correcting .some() Method Usage Fixed Issue with createNavs and removeNavs Functions by Correcting .some() Method Usage Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

joomla-tab createNavs and removeNavs will never Execute
1 participant