Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate GitHub, Slack, and main #52

Open
MartinKolarik opened this issue Sep 20, 2023 · 6 comments · May be fixed by #92
Open

Separate GitHub, Slack, and main #52

MartinKolarik opened this issue Sep 20, 2023 · 6 comments · May be fixed by #92

Comments

@MartinKolarik
Copy link
Member

  • The GitHub app is currently nested in the Slack app
  • The Discord app, although in its own package (and currently disabled), is being loaded from the Slack app to run

Refactor this so that there are three independent Discord, GitHub, and Slack packages, and then possibly a "main" package, that loads and starts all three.

@radulucut
Copy link
Collaborator

@MartinKolarik are you thinking having these running on a different port each, behind nginx or just one node process?

@MartinKolarik
Copy link
Member Author

For now, let's just have each app export its own middleware that gets mounted on the main package. So 1 process but clear structure.

@radulucut
Copy link
Collaborator

@globalping

@globalping
Copy link

Failed to process command \--.

Invalid argument "\--" for "command"!
Expected "ping, traceroute, dns, mtr, http, auth, limits".

Documentation and Support: https://github.com/jsdelivr/globalping

@radulucut
Copy link
Collaborator

@globalping ping google.com

@globalping
Copy link

Here are the results for ping google.com

Syracuse (NY), US, NA, Verizon Business (AS701)

PING google.com (142.251.179.138) 56(84) bytes of data.
64 bytes from pd-in-f138.1e100.net (142.251.179.138): icmp_seq=1 ttl=59 time=23.2 ms
64 bytes from pd-in-f138.1e100.net (142.251.179.138): icmp_seq=2 ttl=59 time=23.0 ms
64 bytes from pd-in-f138.1e100.net (142.251.179.138): icmp_seq=3 ttl=59 time=20.7 ms

--- google.com ping statistics ---
3 packets transmitted, 3 received, 0% packet loss, time 1002ms
rtt min/avg/max/mdev = 20.715/22.316/23.217/1.135 ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants