You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Similarly to the previous issue, but on a different rule, no-noninteractive-element-interactions should allow <label/> to accept event handlers like onClick. In this example, <label/> is used to shift focus to the <input/> upon click. So <label/> is not a non-interactive element.
Sometimes adding custom onClick is needed to support logging etc.
The text was updated successfully, but these errors were encountered:
Hi @jessebeach, sorry to ping you right after dialog is resolved. But is there any update on this as well? Please let us know if there's something we can do to help!
Sometimes adding custom onClick is needed to support logging etc.
This isn't something that this project can support. Any element could conceivably have a click handler added to it to support logging. I recommend either adding a suppression comment to suppress the warning or capture events for logging at the document rather than at each individual element.
Click handlers should be added to the control elements themselves, not the labels that describe them. If a label contains a control element, it will become clickable...this is something the browser client does automatically in this case.
Hi @jessebeach, thanks for looking into this! 🙏 I'll probably go ahead with suppressing existing ones but still enable to rule so that we can avoid similar cases in the future.
Similarly to the previous issue, but on a different rule,
no-noninteractive-element-interactions
should allow<label/>
to accept event handlers likeonClick
. In this example,<label/>
is used to shift focus to the<input/>
upon click. So<label/>
is not a non-interactive element.Sometimes adding custom
onClick
is needed to support logging etc.The text was updated successfully, but these errors were encountered: