Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Commented all_keys_in_defsrc #1466

Closed
IndigoGollum opened this issue Jan 5, 2025 · 2 comments
Closed

Documentation: Commented all_keys_in_defsrc #1466

IndigoGollum opened this issue Jan 5, 2025 · 2 comments
Labels
enhancement New feature or request

Comments

@IndigoGollum
Copy link

Is your feature request related to a problem? Please describe.

Some of the keys here are unclear in their meaning, like for example "102d". So i've added comments after every line, except where it's a single character with an obvious meaning or where it's something i don't understand.

Describe the solution you'd like.

Replace https://github.com/jtroo/kanata/blob/main/cfg_samples/all_keys_in_defsrc.kbd with my commentated version.

Describe alternatives you've considered.

Get someone who actually understands this stuff to add comments to this document.

Additional context

The fixed file is here: https://pastebin.com/CaT6dGsP

@IndigoGollum IndigoGollum added the enhancement New feature or request label Jan 5, 2025
@jtroo
Copy link
Owner

jtroo commented Jan 7, 2025

I'd forgotten about this file. It's probably out of date and missing some named keys. Probably better to move the file to a test directory instead of samples directory, and make something new linked in the configuration guide somewhere if further work is done at all.

@jtroo
Copy link
Owner

jtroo commented Jan 11, 2025

bb3bdbf

@jtroo jtroo closed this as completed Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants