Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URLPatternList defined in source but not exported in dist #36

Closed
bennypowers opened this issue Aug 29, 2021 · 7 comments
Closed

URLPatternList defined in source but not exported in dist #36

bennypowers opened this issue Aug 29, 2021 · 7 comments

Comments

@bennypowers
Copy link

import { URLPatternList } from 'https://unpkg.com/[email protected]/dist/index.js?module';

import not found: URLPatternList

Indeed, it's defined in /src, but not in /dist

@kenchris
Copy link
Owner

@wanderview what is the spec status of URLPatternList?

@wanderview
Copy link
Contributor

We haven't figured out the API yet and I think it may change from the original based on feedback I got on ordering, finding the best route in a set, etc. See here.

I would recommend removing it from the polyfill for now. I intend to work on it further after we get the initial API shipped.

@bennypowers
Copy link
Author

Thanks for the feedback @wanderview

FYI my case is your typical SPA router but this time its Lit ReactiveControllers. The service worker stuff is super cool, but i'm not focused on that atm.

Thanks for working on this v. nifty spec

@wanderview
Copy link
Contributor

If you have time, it would help if you posted in the spec issue what kind of features you need out of the list. Does it need to be supported, have fast lookup, etc? How do you define "best match"? Sorting by particular URL components? This kind of feedback will help us figure out a reasonable API shape.

@kenchris
Copy link
Owner

Closing as this was on purpose. Maybe we should remove the code

@hax
Copy link

hax commented Jun 14, 2023

It seems chrome already land URLPatternList behind the flag. So maybe it's the time to reopen the issue?

@kenchris
Copy link
Owner

@hax does it have WPT test cases we can use to make sure it works as intended?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants