Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pydocstyle release 6.2.0 breaks pylama #232

Open
cjkirk09 opened this issue Jan 3, 2023 · 2 comments · May be fixed by #233
Open

Pydocstyle release 6.2.0 breaks pylama #232

cjkirk09 opened this issue Jan 3, 2023 · 2 comments · May be fixed by #233

Comments

@cjkirk09
Copy link

cjkirk09 commented Jan 3, 2023

With the release of pydocstyle 6.2.0, they changed the method signature of PyDocChecker().check_source to have an additional parameter
https://github.com/PyCQA/pydocstyle/pull/546/files#diff-8036a1f043bf5856770399b0a1b5b13e7fc59cd1fc2e6bc2d8ca93f49a5d3406R134

def check_source(
    self,
    source,
    filename,
    ignore_decorators=None,
    property_decorators=None,
    ignore_inline_noqa=False,
)

So now it is passing in the ignore_inline_noqa value to the property_decorators param in
pylama_pycodestyle.py

for err in PyDocChecker().check_source(
    ctx.source,
    ctx.filename,
    params.get("ignore_decorators"),
    params.get("ignore_inline_noqa", False),
):
@sambhav sambhav mentioned this issue Jan 5, 2023
Closed
@johannesjh johannesjh mentioned this issue Jan 5, 2023
Merged
villainy added a commit to villainy/pylama that referenced this issue Jan 9, 2023
@villainy
fix: pydocstyle kwargs klen#232
7795731
@villainy villainy linked a pull request Jan 9, 2023 that will close this issue
Open
@ddnomad
Copy link

ddnomad commented Feb 1, 2023

Any updates on this one?

real-yfprojects added a commit to real-yfprojects/req2flatpak that referenced this issue Feb 14, 2023
@real-yfprojects
Lock pydocstyle to <=6.2.
4555172 
Pydocstyle is a pylama dependency. However pylama doesn't support the newest pydocstyle version. See klen/pylama#232.

* poetry.lock: Update.

* pyproject.toml: Lock pydocstyle version.
real-yfprojects added a commit to real-yfprojects/req2flatpak that referenced this issue Feb 14, 2023
@real-yfprojects
Lock pydocstyle to <6.2.
34f72c1 
Pydocstyle is a pylama dependency. However pylama doesn't support the newest pydocstyle version. See klen/pylama#232.

* poetry.lock: Update.

* pyproject.toml: Lock pydocstyle version.
@real-yfprojects real-yfprojects mentioned this issue Feb 14, 2023
Merged
real-yfprojects added a commit to johannesjh/req2flatpak that referenced this issue Feb 19, 2023
@real-yfprojects
Lock pydocstyle to <6.2.
7d9899b 
Pydocstyle is a pylama dependency. However pylama doesn't support the newest pydocstyle version. See klen/pylama#232.

* poetry.lock: Update.

* pyproject.toml: Lock pydocstyle version.
@ehanson8 ehanson8 mentioned this issue Feb 21, 2023
Merged
7 tasks
@monasticus
Copy link

When this fix is going to be published?

@martijnjanssen martijnjanssen mentioned this issue May 7, 2023
Merged
ovsrobot pushed a commit to ovsrobot/dpdk that referenced this issue Nov 6, 2023
@jlinkes @ovsrobot
dts: add docstring checker
3b1d823 
Python docstrings are the in-code way to document the code. The
docstring checker of choice is pydocstyle which we're executing from
Pylama, but the current latest versions are not complatible due to [0],
so pin the pydocstyle version to the latest working version.

[0] klen/pylama#232

Signed-off-by: Juraj Linkeš <[email protected]>
Signed-off-by: 0-day Robot <[email protected]>
ovsrobot pushed a commit to ovsrobot/dpdk that referenced this issue Nov 8, 2023
@jlinkes @ovsrobot
dts: add docstring checker
f998cc2 
Python docstrings are the in-code way to document the code. The
docstring checker of choice is pydocstyle which we're executing from
Pylama, but the current latest versions are not complatible due to [0],
so pin the pydocstyle version to the latest working version.

[0] klen/pylama#232

Signed-off-by: Juraj Linkeš <[email protected]>
Signed-off-by: 0-day Robot <[email protected]>
ovsrobot pushed a commit to ovsrobot/dpdk that referenced this issue Nov 15, 2023
@jlinkes @ovsrobot
dts: add docstring checker
6106a7d 
Python docstrings are the in-code way to document the code. The
docstring checker of choice is pydocstyle which we're executing from
Pylama, but the current latest versions are not complatible due to [0],
so pin the pydocstyle version to the latest working version.

[0] klen/pylama#232

Signed-off-by: Juraj Linkeš <[email protected]>
Signed-off-by: 0-day Robot <[email protected]>
ovsrobot pushed a commit to ovsrobot/dpdk that referenced this issue Nov 23, 2023
@jlinkes @ovsrobot
dts: add docstring checker
371366b 
Python docstrings are the in-code way to document the code. The
docstring checker of choice is pydocstyle which we're executing from
Pylama, but the current latest versions are not complatible due to [0],
so pin the pydocstyle version to the latest working version.

[0] klen/pylama#232

Signed-off-by: Juraj Linkeš <[email protected]>
Signed-off-by: 0-day Robot <[email protected]>
ovsrobot pushed a commit to ovsrobot/dpdk that referenced this issue Dec 4, 2023
@jlinkes @ovsrobot
dts: add docstring checker
437311f 
Python docstrings are the in-code way to document the code. The
docstring checker of choice is pydocstyle which we're executing from
Pylama, but the current latest versions are not complatible due to [0],
so pin the pydocstyle version to the latest working version.

[0] klen/pylama#232

Signed-off-by: Juraj Linkeš <[email protected]>
Signed-off-by: 0-day Robot <[email protected]>
dpdk-replication pushed a commit to DPDK/dpdk that referenced this issue Dec 21, 2023
@jlinkes @tmonjalo
dts: add docstring checker
06ce778 
Python docstrings are the in-code way to document the code. The
docstring checker of choice is pydocstyle which we're executing from
Pylama, but the current latest versions are not complatible due to [0],
so pin the pydocstyle version to the latest working version.

[0] klen/pylama#232

Signed-off-by: Juraj Linkeš <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: pydocstyle kwargs #232 villainy/pylama
3 participants
@ddnomad @cjkirk09 @monasticus