Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document Trigger Delivery Spec aspects #3772

Open
matzew opened this issue Jun 10, 2021 · 5 comments
Open

Document Trigger Delivery Spec aspects #3772

matzew opened this issue Jun 10, 2021 · 5 comments
Labels
hacktoberfest Issues that can be picked up by contributors for Hacktoberfest! kind/eventing lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@matzew
Copy link
Member

matzew commented Jun 10, 2021 •
edited by abrennan89
Loading

Describe the change you'd like to see

The documentation on "Event Delivery" does not have any example on its usage for triggers.
Example code:
https://github.com/knative/eventing/blob/d5f8b90a0050dac74ec534da3d84468496f38bd7/test/rekt/resources/trigger/trigger_test.go#L236-L274

Additional context
Add any other context or screenshots about the feature request here.

Looking here: https://knative.dev/development/developer/eventing/event-delivery/

I don't see a mention of Triggers, than jumping here https://knative.dev/development/eventing/broker/triggers/

or https://knative.dev/development/developer/eventing/event-delivery/

I am also not seeing anything
@abrennan89 abrennan89 added kind/eventing Developer guide kind/good-first-issue Denotes an issue ready for a new contributor. labels Jun 10, 2021
@snneji
Copy link
Contributor

snneji commented Jul 14, 2021

/priority medium

This was referenced Sep 5, 2021
Open
Open
Open
Open
@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 17, 2021
@abrennan89 abrennan89 removed kind/good-first-issue Denotes an issue ready for a new contributor. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/medium Developer guide labels Dec 3, 2021
@abrennan89 abrennan89 added this to the Icebox milestone Dec 3, 2021
@github-actions
Copy link

github-actions bot commented Mar 4, 2022

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 4, 2022
@github-actions github-actions bot closed this as completed Apr 3, 2022
@abrennan89 abrennan89 reopened this Aug 24, 2022
@abrennan89 abrennan89 added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 24, 2022
@abrennan89 abrennan89 self-assigned this Aug 24, 2022
@abrennan89 abrennan89 removed this from the Icebox milestone Aug 24, 2022
@snneji snneji moved this to In progress in Docs WG Roadmap Aug 30, 2022
@abrennan89
Copy link
Contributor

Related openshift/openshift-docs#49552

@abrennan89 abrennan89 removed their assignment Sep 6, 2022
@abrennan89 abrennan89 moved this from In progress to Ready to work in Docs WG Roadmap Sep 6, 2022
@abrennan89 abrennan89 added the hacktoberfest Issues that can be picked up by contributors for Hacktoberfest! label Oct 10, 2022
@abrennan89
Copy link
Contributor

New snippet should be added to https://knative.dev/docs/eventing/triggers/ and the event delivery section

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hacktoberfest Issues that can be picked up by contributors for Hacktoberfest! kind/eventing lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@matzew @snneji @abrennan89 @knative-prow-robot