Skip to content
This repository has been archived by the owner on Dec 6, 2024. It is now read-only.

Add more client stats #49

Open
stevej opened this issue Apr 28, 2017 · 3 comments
Open

Add more client stats #49

stevej opened this issue Apr 28, 2017 · 3 comments

Comments

@stevej
Copy link

stevej commented Apr 28, 2017

Debugging the mystery of the failing iperf tests would have been easier had /metrics shown me that there were other clients connected and where they were connected from.

@olix0r
Copy link
Member

olix0r commented May 2, 2017

We probably shouldn't expose any per-endpoint metrics by default unless we have a good way of garbage collecting unused enpdpoints (i.e. we'd need to ensure that dropping an endpoint removes its counters, but only after they've been reported... it's a bit tricky).

What non-per-endpoint metrics would have helped you?

@stevej
Copy link
Author

stevej commented May 3, 2017

non-per-endpoint metric: Unique number of currently connected clients.

I would have expected 1 when running my load test with a concurrency of 1. Seeing > 1 would have led me to login to the host and use ss to see who else was connected.

olix0r added a commit that referenced this issue Jun 10, 2017
linkerd-tcp 0.1.0 constitues a major rewrite.

Previously, linkerd-tcp did not properly utilize tokio's task model, which lead
to a number of performance and correctness problems. Furthermore, linkerd-tcp's
configuration interface was substantially different from linkerd's, which
caused some confusion.

Now, linkerd-tcp has been redesigned:
- to better-leverage tokio's reactor;
- to support connection and stream timeouts;
- to provide much richer metrics insight;
- to be structured like a linkerd-style router;
- general correctness improvements.

Fixes #26 #40 #49 #50
Depends on linkerd/tacho#20
olix0r added a commit that referenced this issue Jun 13, 2017
linkerd-tcp 0.1.0 constitutes a major rewrite.

Previously, linkerd-tcp did not properly utilize tokio's task model, which lead
to a number of performance and correctness problems. Furthermore, linkerd-tcp's
configuration interface was substantially different from linkerd's, which
caused some confusion.

Now, linkerd-tcp has been redesigned:
- to better-leverage tokio's reactor;
- to support connection and stream timeouts;
- to provide much richer metrics insight;
- to be structured like a linkerd-style router;
- general correctness improvements.

Fixes #26 #40 #49 #50
Depends on linkerd/tacho#20
@tamird
Copy link
Contributor

tamird commented Jun 17, 2017

@olix0r this should have been closed by ea507f7.

FYI this doesn't do what you think:

Fixes #1 #2 #3"

Each issue needs its own "fixes":

Fixes #1
Fixes #2
Fixes #3

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants