This repository has been archived by the owner on Dec 6, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 28
Add more client stats #49
Comments
We probably shouldn't expose any per-endpoint metrics by default unless we have a good way of garbage collecting unused enpdpoints (i.e. we'd need to ensure that dropping an endpoint removes its counters, but only after they've been reported... it's a bit tricky). What non-per-endpoint metrics would have helped you? |
non-per-endpoint metric: Unique number of currently connected clients. I would have expected 1 when running my load test with a concurrency of 1. Seeing > 1 would have led me to login to the host and use |
olix0r
added a commit
that referenced
this issue
Jun 10, 2017
linkerd-tcp 0.1.0 constitues a major rewrite. Previously, linkerd-tcp did not properly utilize tokio's task model, which lead to a number of performance and correctness problems. Furthermore, linkerd-tcp's configuration interface was substantially different from linkerd's, which caused some confusion. Now, linkerd-tcp has been redesigned: - to better-leverage tokio's reactor; - to support connection and stream timeouts; - to provide much richer metrics insight; - to be structured like a linkerd-style router; - general correctness improvements. Fixes #26 #40 #49 #50 Depends on linkerd/tacho#20
Merged
olix0r
added a commit
that referenced
this issue
Jun 13, 2017
linkerd-tcp 0.1.0 constitutes a major rewrite. Previously, linkerd-tcp did not properly utilize tokio's task model, which lead to a number of performance and correctness problems. Furthermore, linkerd-tcp's configuration interface was substantially different from linkerd's, which caused some confusion. Now, linkerd-tcp has been redesigned: - to better-leverage tokio's reactor; - to support connection and stream timeouts; - to provide much richer metrics insight; - to be structured like a linkerd-style router; - general correctness improvements. Fixes #26 #40 #49 #50 Depends on linkerd/tacho#20
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Debugging the mystery of the failing iperf tests would have been easier had
/metrics
shown me that there were other clients connected and where they were connected from.The text was updated successfully, but these errors were encountered: