Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LINKERD2_PROXY_TRACE_COLLECTOR_SVC_ADDR - Should be able to set this to the Node IP. #13373

Open
jseiser opened this issue Nov 22, 2024 · 0 comments

Comments

@jseiser
Copy link
Contributor

jseiser commented Nov 22, 2024

What problem are you trying to solve?

Linkerd doesnt actually play nicely when using the OTEL Collector.

You can run the collector as a Daemonset, and utilize the k8s resource attributes to provide additional metadata to the span. You should only be looking this information up for pod's that are running on the same host as the collector processing the spand.

When running as an agent, it is important to apply a discovery filter so that the processor only discovers pods from the same host that it is running on. Not using such a filter can result in unnecessary resource usage especially on very large clusters.

Your other option is to run the collector as a agent, but then you lose the ability to enrich the spans with that data.

How should the problem be solved?

Should be able to configure LINKERD2_PROXY_TRACE_COLLECTOR_SVC_ADDR to utilize the already existing spec.nodeName ENV var.

Any alternatives you've considered?

Just deal with broken traces.

How would users interact with this feature?

Ideally as a helm input.

Would you like to work on this feature?

no

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant