Focus after select not focusing

[Amerlander]

When I do focusAfterSelect='true' the search results stay open after an selection, but the input doesn't get focus. I have to select it with the mouse to change the text in it.
The console error says TypeError: searchRef.focus is not a function.

I wasnt able to get the input focused, but the error message can be removed by changing

    if (focusAfterSelect) searchRef.focus();

    hideDropdown = true;

to

        if (!focusAfterSelect)   hideDropdown = true;

[metonym]

This one's on me. A breaking change in svelte-search was to remove the exported focus function in favor of binding to ref.

I think the fix would be to bind to the ref prop and perform a null check before focusing the input element.

<Search
    {...$$restProps}
-  bind:this={searchRef}
+  bind:ref={searchRef}

[Amerlander]

When focus after select enabled the hide dropdown should not be called:

if (focusAfterSelect) {
  searchRef.focus();
} else {
  hideDropdown = true;
}

svelte-typeahead/src/Typeahead.svelte

Line 84 in ecbbfa6

hideDropdown = true;

Before the fix it wasn't called because the searchRef.focus() failed and stopped further execution.
Or was this a bug and the intention is to close the result list even when focus is keept?

[metonym]

Yes, it's intentional to hide the dropdown after selecting or a result or blurring the input.

[Amerlander]

But with getting the input focused again it should open again (or just not got closed).

Now when having focusAfterSelect='true' and selecting an item the input focuses, but the result list does not show up.
Clicking in the input again will not open the results what I would expect as a user, since the input is already focused.

[Amerlander]

Maybe just changing the order would be the solution. Then all events will get called and the resultset will stay open as expected:

 hideDropdown = true;
if (focusAfterSelect)  searchRef.focus();

[metonym]

from a UX perspective, Id prefer the dropdown to be closed after searching and selecting a result.

[Amerlander]

I totally agree when inputAfterSelect is set to clear or update - in the first case the result set will close anyways, in the other case the result set will be equal to the selected item and it doesn't make much sense to show it.

I understood Typeahead more as a search, than an input field, what was the reason for introducing keep for me.
In that combination it feels pretty much like a bug, when the results are closing and cant be opened by focusing the input.

Here is a sample with inputAfterSelect set to keepand focusAfterSelect to true:

select_closing.mp4

Compared to:

select_staying.mp4

The video is made on the code of this pr without the user styling applied: #13