Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for CMK options in workflows #4249

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

tamirkamara
Copy link
Collaborator

Resolves #4148

What is being addressed

Adding support for CMK GH Actions workflows.

How is this addressed

  • Add 3 new options to the workflows.
  • Add Terraform validation for the new options + config schema (this is unrelated to GH actions)

Copy link

github-actions bot commented Jan 5, 2025

Unit Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit ebf3e42.

♻️ This comment has been updated with latest results.

@tamirkamara tamirkamara marked this pull request as ready for review January 5, 2025 15:47
@tamirkamara
Copy link
Collaborator Author

/test

Copy link

github-actions bot commented Jan 5, 2025

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/12620906900 (with refid 8c2167bd)

(in response to this comment from @tamirkamara)

@tamirkamara
Copy link
Collaborator Author

/test

@tamirkamara tamirkamara enabled auto-merge (squash) January 6, 2025 06:35
Copy link

github-actions bot commented Jan 6, 2025

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/12627794742 (with refid 8c2167bd)

(in response to this comment from @tamirkamara)

@tamirkamara
Copy link
Collaborator Author

/test

Copy link

github-actions bot commented Jan 6, 2025

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/12632163170 (with refid 8c2167bd)

(in response to this comment from @tamirkamara)

@marrobi marrobi requested a review from Copilot January 6, 2025 12:07
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 15 changed files in this pull request and generated 3 comments.

Files not reviewed (10)
  • config_schema.json: Language not supported
  • core/terraform/variables.tf: Language not supported
  • core/version.txt: Language not supported
  • devops/terraform/variables.tf: Language not supported
  • devops/version.txt: Language not supported
  • .github/workflows/pr_comment_bot.yml: Evaluated as low risk
  • docs/tre-admins/environment-variables.md: Evaluated as low risk
  • docs/tre-admins/setup-instructions/cicd-pre-deployment-steps.md: Evaluated as low risk
  • .github/workflows/deploy_tre.yml: Evaluated as low risk
  • .github/workflows/deploy_tre_branch.yml: Evaluated as low risk
Comments suppressed due to low confidence (1)

.github/actions/devcontainer_run_command/action.yml:141

  • [nitpick] The description for 'ENCRYPTION_KV_NAME' is empty. It should be more descriptive, e.g., 'The name of the Key Vault for CMK encryption'.
description: ""

docs/tre-admins/setup-instructions/workflows.md Outdated Show resolved Hide resolved
.github/workflows/deploy_tre_reusable.yml Show resolved Hide resolved
.github/workflows/deploy_tre_reusable.yml Show resolved Hide resolved
Copy link
Member

@marrobi marrobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM albeit haven't tested, couple of comments/questions.

Has this been tested somewhere - the workflows with CMK enabled? Be good to see a successful run.

@jonnyry jonnyry self-requested a review January 6, 2025 12:14
@tamirkamara
Copy link
Collaborator Author

/test

Copy link

github-actions bot commented Jan 6, 2025

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/12632841658 (with refid 8c2167bd)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara disabled auto-merge January 6, 2025 13:02
@tamirkamara tamirkamara marked this pull request as draft January 6, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding the enable_cmk_encryption option to the CI
5 participants