You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
+// This file is here just to declare the external dependencies
+// that are used by the backend package. This allows to track
+// their versions in a single patch file.
It looks like we have to import each package to make sure go mod vendor picks it up, but I don't see this documented. (I'm also not 100% I have the reason right, didn't get a chance to poke around locally.)
If that's right, it's a little concerning that the vendoring patch has to "predict" what packages will be used by later patches--not a practical concern most likely (we have very few, pretty consistent, packages), but I want to understand better how a mistake is detected and make sure this is as maintainable and documented as necessary.
The text was updated successfully, but these errors were encountered:
go/patches/0002-Vendor-crypto-backends.patch
Lines 210 to 223 in dddedbf
It looks like we have to import each package to make sure
go mod vendor
picks it up, but I don't see this documented. (I'm also not 100% I have the reason right, didn't get a chance to poke around locally.)If that's right, it's a little concerning that the vendoring patch has to "predict" what packages will be used by later patches--not a practical concern most likely (we have very few, pretty consistent, packages), but I want to understand better how a mistake is detected and make sure this is as maintainable and documented as necessary.
The text was updated successfully, but these errors were encountered: