Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The ability to toggle the split direction of a pane #10665

Closed
Tracked by #1000
Rosefield opened this issue Jul 15, 2021 · 7 comments · Fixed by #10713
Closed
Tracked by #1000

The ability to toggle the split direction of a pane #10665

Rosefield opened this issue Jul 15, 2021 · 7 comments · Fixed by #10713
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal Backlog

Comments

@Rosefield
Copy link
Contributor

Description of the new feature/enhancement

Once a pane was split, it would be nice to change the orientation of that split. Having a hotkey to toggle the split orientation of the currently active pane would allow changing how the terminal looks without needing to close and recreate a terminal.
E.G.
Create two panes

image

and then swap them to look like

image

and vice versa.

Proposed technical implementation details (optional)
@Rosefield Rosefield added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Jul 15, 2021
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jul 15, 2021
@zadjii-msft
Copy link
Member

Oh huh, I suppose we don't have a issue for this one in #1000 yet. This doesn't seem too hard, wire up a keybinding, and just toggle the orientation of the split on the parent of the active pane. Easy enough!

@zadjii-msft zadjii-msft added Area-UserInterface Issues pertaining to the user interface of the Console or Terminal good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. labels Jul 15, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jul 15, 2021
@zadjii-msft zadjii-msft added this to the Terminal Backlog milestone Jul 15, 2021
@zadjii-msft zadjii-msft mentioned this issue Jul 15, 2021
Open
59 tasks
@NishantChandla
Copy link

@zadjii-msft I would like to take up this issue. What hotkey should be set to toggle split direction?

@jelonmusk
Copy link

Hi
I am a rookie contributor. This might sound silly but should the feature be developed in a specific language only or any programming language can be used?

@zadjii-msft
Copy link
Member

@NishantChandla / @jelonmusk go right ahead!

I don't think we really want to have this bound to a key by default right now. If you create an action like togglePaneOrientation, once it's all wired up, you should be able to execute the action through the Command Palette without needing to bind a dedicated key for it.

This might sound silly but should the feature be developed in a specific language only or any programming language can be used?

The entire Terminal is written in C++, so you'll have to use that.

@Rosefield
Copy link
Contributor Author

@NishantChandla @jelonmusk if you two choose not to do this task I was also planning on doing it, just let me know.

@NishantChandla
Copy link

@Rosefield As you have created the issue, you can work on this!

@Rosefield Rosefield mentioned this issue Jul 19, 2021
Merged
6 tasks
@ghost ghost added the In-PR This issue has a related PR label Jul 19, 2021
@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jul 22, 2021
@ghost ghost closed this as completed in #10713 Aug 2, 2021
ghost pushed a commit that referenced this issue Aug 2, 2021
@Rosefield
Add the ability to toggle a pane's split direction (#10713)
e710833 
<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? -->
## Summary of the Pull Request
Add the ability to toggle a pane's split direction
- Switch from horizontal to vertical split (and vice versa)
- Propogate new borders through to children.

<!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> 
## References
#10665 

<!-- Please review the items on the PR checklist before submitting-->
## PR Checklist
* [x] Closes #10665
* [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA
* [ ] Tests added/passed
* [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx
* [x] Schema updated.
* [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

<!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here -->
## Detailed Description of the Pull Request / Additional comments

<!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well -->
## Validation Steps Performed
Ran terminal, created multiple panes in different orientations, ran command through command palate and verified that they displayed properly in the new orientation.
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Aug 2, 2021
@ghost
Copy link

ghost commented Aug 31, 2021

🎉This issue was addressed in #10713, which has now been successfully released as Windows Terminal Preview v1.11.2421.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal Backlog
Development

Successfully merging a pull request may close this issue.

Add the ability to toggle a pane's split direction Rosefield/terminal
5 participants
@DHowett @Rosefield @zadjii-msft @jelonmusk @NishantChandla