Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[http-client-python] Align param type in description #5503

Open
YalinLi0312 opened this issue Jan 6, 2025 · 1 comment · May be fixed by #5556
Open

[http-client-python] Align param type in description #5503

YalinLi0312 opened this issue Jan 6, 2025 · 1 comment · May be fixed by #5556
Assignees
Labels
emitter:client:python Issue for the Python client emitter: @typespec/http-client-python

Comments

@YalinLi0312
Copy link
Member

Got a comment from a tsp migration PR: Azure/azure-sdk-for-python#37438 (comment)

This is the description of param credential in auto generated async client:
Image

Expected:
It should be AsyncTokenCredential in param description as well.

@markcowl markcowl added the emitter:client:python Issue for the Python client emitter: @typespec/http-client-python label Jan 7, 2025
@iscai-msft
Copy link
Member

@YalinLi0312 we like our type descriptions to remain sync / async neutral, so it's kind of a difficult change actually to have it show up as async token credential in our documentation. How would you feel about "token credential type" instead of "TokenCredential type", so it's not directly associated with the TokenCredential object. "Token credential" as a concept is sansio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
emitter:client:python Issue for the Python client emitter: @typespec/http-client-python
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants