Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The punycode module is deprecated. #15246

Open
1 task
AmaseCocoa opened this issue Jan 9, 2025 · 1 comment
Open
1 task

The punycode module is deprecated. #15246

AmaseCocoa opened this issue Jan 9, 2025 · 1 comment
Labels
packages/backend Server side specific issue/PR 💚Refactor Rewriting code without changing behavior

Comments

@AmaseCocoa
Copy link
Contributor

AmaseCocoa commented Jan 9, 2025

💡 Summary

Node.jsのpunycodeモジュールは非推奨になっているようです

https://nodejs.org/docs/latest-v22.x/api/punycode.html
https://nodejs.org/docs/latest-v20.x/api/punycode.html

代替としてはPunycode.jsやWHATWG URL APIのdomainToASCIIやdomainToUnicodeが使えると思います

🥰 Expected Behavior

警告が表示されない

🤬 Actual Behavior

警告が表示される

📝 Steps to Reproduce

  1. Misskeyを実行する

💻 Frontend Environment

* Model and OS of the device(s):
* Browser:
* Server URL:
* Misskey:

🛰 Backend Environment (for server admin)

* Installation Method or Hosting Service: 手動
* Misskey: v2024.11.1-alpha.0
* Node: v22.13.0
* PostgreSQL: 16
* Redis: 7.4.0
* OS and Architecture: Ubuntu 22.04 LTS x64

Do you want to address this bug yourself?

  • Yes, I will patch the bug myself and send a pull request
@anatawa12
Copy link
Member

punycode.js がdependenciesで指定されてますが"punycode"をimportするとpunycode.jsではなくnodejsのモジュールを読んでしまうことがwarnの原因になってる模様なので"punycode/"に書き換えることで治りそうです

@KisaragiEffective KisaragiEffective added packages/backend Server side specific issue/PR 💚Refactor Rewriting code without changing behavior and removed ⚠️bug? This might be a bug labels Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR 💚Refactor Rewriting code without changing behavior
Projects
Development

No branches or pull requests

3 participants