Skip to content
This repository has been archived by the owner on Apr 3, 2019. It is now read-only.

fork and fix grunt-rev from whatever version we are using, or just write our own. #4190

Closed
jrgm opened this issue Sep 25, 2016 · 7 comments
Closed

Comments

@jrgm
Copy link
Contributor

jrgm commented Sep 25, 2016

Unsupported module, and the md5 is totally wrong. HEAD of the repo does not even install or pass on travis. npm ftw!

@shane-tomlinson
Copy link

grunt-usemin is no longer maintained either - https://github.com/yeoman/grunt-usemin

@shane-tomlinson
Copy link

This and #4180 seem to be the same issue. One is a suggestion, one is an observable effect. Should we keep only one of these open?

@pdehaan
Copy link
Contributor

pdehaan commented Sep 26, 2016

Looks like there is an open PR for this at sebdeckers/grunt-rev#32, but that repo seems unmaintined for the past ~4 years. (same w/ grunt-filerev)

Or we could just write our own module, and then unmaintain it.

@jrgm
Copy link
Contributor Author

jrgm commented Sep 26, 2016

... and that pull request is wrong ;-)

@pdehaan
Copy link
Contributor

pdehaan commented Sep 26, 2016

Ah, I saw your { encoding: null } comment in #4180 and saw https://github.com/cbas/grunt-rev/pull/32/files#diff-e7578b93a9244a3063f6222e6c27a72fR21 and assumed it was the same solution. Fair enough... I'll stop talking now.

@vladikoff
Copy link
Contributor

fixed, there is a pr with its own issue

@jrgm
Copy link
Contributor Author

jrgm commented Sep 27, 2016

Actually, that other PR would get the right result, but leaves behind an unused parameter. If encoding:null, the a Buffer is passed to update, in which case the fileEncoding is ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants