Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LDAP Node - Bug / Enhancement #12821

Open
jkoch22 opened this issue Jan 23, 2025 · 1 comment
Open

LDAP Node - Bug / Enhancement #12821

jkoch22 opened this issue Jan 23, 2025 · 1 comment
Labels
in linear Issue or PR has been created in Linear for internal review

Comments

@jkoch22
Copy link

jkoch22 commented Jan 23, 2025

Bug Description

On the LDAP Update node the replace and delete operations don't allow for null values. The LDAPts module allows you for a null value to be specified on either of these operations to clear the attribute (I created a crude script trying this and it worked as intended). I think for the remove operation, it probably makes sense to be able specify a value as a sort of "filter" but still allow the user to clear the attribute regardless of whether they know the current value or not.

Currently. if I don't specify a value on the remove operation, LDAP (Active Directory) returns an error due to it trying to update the attribute with an empty string. If I use a null expression, I get an error from n8n stating argument must be a string (was: object) [item 0].

To Reproduce

  1. Set up LDAP node with credentials
  2. Set to Update operation
  3. Specify DN of user to update
  4. Select Remove under Update Attributes and specify attribute to clear.
  5. Leave blank or specify null expression.

Expected behavior

On the Remove operation, the attribute is cleared without specifying a value.
On the Replace operation, the attribute is cleared when the value isn't specified or is null.

Operating System

Debian 12

n8n Version

1.75.2

Node.js Version

N/A

Database

SQLite (default)

Execution mode

main (default)

@Joffcom
Copy link
Member

Joffcom commented Jan 23, 2025

Hey @jkoch22,

We have created an internal ticket to look into this which we will be tracking as "N8N-8221"

@Joffcom Joffcom added the in linear Issue or PR has been created in Linear for internal review label Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in linear Issue or PR has been created in Linear for internal review
Projects
None yet
Development

No branches or pull requests

2 participants