Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add component owners to js-contrib-triagers role #2600

Open
1 of 3 tasks
JamieDanielson opened this issue Dec 11, 2024 · 5 comments
Open
1 of 3 tasks

Add component owners to js-contrib-triagers role #2600

JamieDanielson opened this issue Dec 11, 2024 · 5 comments
Assignees

Comments

@JamieDanielson
Copy link
Member

JamieDanielson commented Dec 11, 2024

As a follow-up to #2548 we want to be consistent with the expectations and automations for component owners.

This issue is for:

  • Add expectations for js-contrib-triager role
  • Confirm current codeowners are members of OTel org
  • Add codeowners to js-contrib-triager role
@pichlermarc
Copy link
Member

Opened #2641 to address the first point ("Add expectations for js-contrib-triager role")

@pichlermarc
Copy link
Member

pichlermarc commented Jan 16, 2025

Alright, this is step 2 "Confirm current codeowners are members of OTel org"

I took a look at the current component-owners, and it looks like the following users are not yet part of the organization:

Hi all, some context for the ping: we're currently adding assigning members that are component owners in this repository to the @open-telemetry/javascript-contrib-triagers role, but to do so, users need to be members of the organization.

Adding to everyone to CODEOWNERS would be the ideal solution to give you all green check-marks for your components, but GitHub does not support that without also giving write permissions to the repository. Therefore, we're adding component owners to @open-telemetry/javascript-contrib-triagers, and ask owners to apply the has:owner-approval label when you approve a PR for your component. The goal of that is to de-facto lift component owner reviews to the same level as approver reviews (scoped to the owner's component).

The role also grants triage permissions to issues, so it should become easier for all of you to triage issues (bugs, feature-requests, ...) that are related to your component. This will also give component owners more autonomy in deciding how to handle certain requests.

Please check here for requirements and steps to become an member of the organization. I think most of you already meet the criteria there. 🙂

The checklist also mentions that you need two sponsors - I've reached out to some other folks based on interactions I remember and have come up with the following list of sponsors (I already de-duped the list when there were >1 sponsors per company):

Component Owner Sponsors
@Ugzuzg @blumamir, @pichlermarc
@abhee11 @trentm, @pichlermarc
@d4nyll @trentm, @pichlermarc
@henrinormak @trentm, @pichlermarc
@JacksonWeber @JamieDanielson, @pichlermarc
@mhennoch @trentm, @pichlermarc
@t2t2 @JamieDanielson, @legendecas, @pichlermarc

Once you have been added to the organization we can assign you to the role. Thanks! 🙂

@t2t2
Copy link
Contributor

t2t2 commented Jan 16, 2025

✅ Joined the org

@pichlermarc
Copy link
Member

pichlermarc commented Jan 22, 2025

Alright I sent out the invites to everyone who's currently on the owners list - I left out current maintainers as they are already assigned to @open-telemetry/javascript-contrib-triagers due to being part of the @open-telemetry/javascript-maintainers group.

I will try to contact the ones that are still pending via other means.

For context, please see #2600 (comment)

Owner Status Components
@JacksonWeber ⚠ membership pending resource-detector-azure
@hectorhdzg ✅ invite sent resource-detector-azure, winston-transport
@jj22ee ✅ invite sent resource-detector-aws, sampler-aws-xray, id-generator-aws-xray, instrumentation-aws-lambda, instrumentation-aws-sdk, propagator-aws-xray
@abhee11 ⚠ membership pending resource-detector-container
@aabmass ✅ invite sent resource-detector-gcp
@punya ✅ invite sent resource-detector-gcp
@kirrg001 ✅ invite sent resource-detector-instana, propagator-instana
@MikeGoldsmith ✅ invite sent baggage-span-processor
@Ugzuzg ✅ invite sent instrumentation-cucumber
@henrinormak ⚠ membership pending instrumentation-dataloader
@seemk ✅ invite sent instrumentation-kafkajs, instrumentation-bunyan, instrumentation-cassandra, instrumentation-net, instrumentation-pino, instrumentation-winston
@mottibec ✅ invite sent instrumentation-socketio
@trivikr ✅ invite sent instrumentation-aws-sdk
@pkanal ✅ invite sent instrumentation-express, instrumentation-document-load
@obecny ✅ invite sent instrumentation-graphql, instrumentation-user-interaction
@naseemkullah ✅ invite sent instrumentation-ioredis
@d4nyll ⚠ membership pending instrumentation-runtime-node
@maryliag ✅ invite sent instrumentation-pg
@david-luna ✅ invite sent instrumentation-undici
@martinkuba ✅ invite sent instrumentation-document-load, plugin-react-load
@t2t2 ✅ invite sent instrumentation-long-task
@mhennoch ✅ invite sent instrumentation-long-task

@JacksonWeber
Copy link
Contributor

Requested membership: open-telemetry/community#2527

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants