You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Are both OTEL_RUBY_EXPORTER_OTLP_SSL_VERIFY_PEER and OTEL_RUBY_EXPORTER_OTLP_SSL_VERIFY_NONE necessary?
defself.ssl_verify_modeifENV.key?('OTEL_RUBY_EXPORTER_OTLP_SSL_VERIFY_PEER')# <- even if it's not set, the outcome will be the same due to the default else clause.OpenSSL::SSL::VERIFY_PEERelsifENV.key?('OTEL_RUBY_EXPORTER_OTLP_SSL_VERIFY_NONE')OpenSSL::SSL::VERIFY_NONEelseOpenSSL::SSL::VERIFY_PEERendend
I feel like keeping only one or the other would make more sense.
Since it has to be enabled by default, I think it would be more intuitive to rename it to to something like OTEL_RUBY_EXPORTER_OTLP_SKIP_SSL_VERIFY.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Are both
OTEL_RUBY_EXPORTER_OTLP_SSL_VERIFY_PEER
andOTEL_RUBY_EXPORTER_OTLP_SSL_VERIFY_NONE
necessary?I feel like keeping only one or the other would make more sense.
Since it has to be enabled by default, I think it would be more intuitive to rename it to to something like
OTEL_RUBY_EXPORTER_OTLP_SKIP_SSL_VERIFY
.Then:
Beta Was this translation helpful? Give feedback.
All reactions