You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The first obvious option to me, is just to place the proto/tonic/* files directly in the proto/ folder. This more-or-less follows the name they got from the upstream opentelemetry-proto repo.
The text was updated successfully, but these errors were encountered:
@psandana - Agree with the change. Moving directly to proto/ dir, or else to src/generated dir ( so src contains proto, generated and transform dirs). And I think it would make sense to keep it non-breaking, by still keeping the tonic as an alias?
If you prefer to keep tonic as an alias, I think it is ok. Why is the reason to keep it as is? If you still plan to remove, just not now, I would suggest adding a deprecation notice.
As mentioned in open-telemetry/opentelemetry-rust-contrib#134 (comment), OpenTelemetry use proto defined structs from this
tonic
module. Despite the name references Tonic, they are pretty generic, not restricted by Tonic scenarios.Thus, I propose to rename the module to better describe the contents.
https://github.com/open-telemetry/opentelemetry-rust/tree/main/opentelemetry-proto/src/proto/tonic
The first obvious option to me, is just to place the
proto/tonic/*
files directly in theproto/
folder. This more-or-less follows the name they got from the upstream opentelemetry-proto repo.The text was updated successfully, but these errors were encountered: