Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mcad-controller-ray-clusterrolebinding refers to the wrong ServiceAccount #21

Closed
guimou opened this issue Nov 2, 2023 · 1 comment · Fixed by project-codeflare/codeflare-operator#400
Assignees

Comments

@guimou
Copy link
Member

guimou commented Nov 2, 2023

The RoleBinding defined at https://github.com/opendatahub-io/codeflare-operator/blob/main/config/rbac/mcad-controller-ray-clusterrolebinding.yaml refers to a ServiceAccount in the openshift-operators namespace:

subjects:
  - kind: ServiceAccount
    name: codeflare-operator-controller-manager
    namespace: openshift-operators

However this specific ServiceAccount is created in the namespace where the operator is deployed, so opendatahub or redhat-ods-applications normally. At least that's what is done using the Kustomize deployment.
So as the RB is pointing to the wrong SA, the Ray cluster cannot be created due to lack of permissions.
Maybe the operator takes care of the corrections automatically, but this is misleading when doing a manual install.

@astefanutti
Copy link

I'd expect Kustomize / the ODH operator (via Kustomize) to override it, but I agree this is misleading.

Note that this ClusterRoleBinding will be removed anyway once project-codeflare/multi-cluster-app-dispatcher#635 is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Status: No status
Development

Successfully merging a pull request may close this issue.

3 participants