Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add runtime add remotes with virtual:__federation__ #645

Merged
merged 2 commits into from
Jan 12, 2025

Conversation

frolovsky
Copy link
Contributor

Description

Documentation for working with virtual:__federation__ has been added. It addresses user questions such as "how to load a module at runtime."
#642

Describes part of the changes from #481.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Code of Conduct and follow the Commit Convention guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link
Contributor

@tobyscott25 tobyscott25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing addition to the docs, I just implemented this in a project and would've loved to have this in the docs for quick reference!

Just one small suggestion, learning about virtual modules in Vite properly helped me understand how this magic worked, so I've just suggested the addition of a note to the relevant page in documentation 😄

README.md Show resolved Hide resolved
@ruleeeer
Copy link
Collaborator

ruleeeer commented Jan 11, 2025

emmm...,Due to conflicts, I am unable to merge this request. Could you adjust the commit by using git rebase?
I should not use the github website to handle conflicts. it looks like the problem is more complicated.
图片

@frolovsky frolovsky force-pushed the docs/virtual-federation branch from 101629a to 20f5a8a Compare January 11, 2025 07:10
@frolovsky
Copy link
Contributor Author

emmm...,Due to conflicts, I am unable to merge this request. Could you adjust the commit by using git rebase? I should not use the github website to handle conflicts. it looks like the problem is more complicated. 图片

Thank you! Resolved conflicts

@ruleeeer ruleeeer merged commit c7b655d into originjs:main Jan 12, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants