Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random mod make objects appear out of playfield #31594

Open
trimix3d opened this issue Jan 20, 2025 · 3 comments
Open

Random mod make objects appear out of playfield #31594

trimix3d opened this issue Jan 20, 2025 · 3 comments

Comments

@trimix3d
Copy link

trimix3d commented Jan 20, 2025

Type

Game behaviour

Bug description

When playing with the random mod, sometimes the hitcircles appears out of the playfield, like shown in the video.

Beatmap of the video: https://osu.ppy.sh/beatmapsets/1003201#osu/2099668

Screenshots or videos

osu._2025.01.20-15.26.mp4

Version

2025.118.2-lazer

Logs

compressed-logs.zip

@TriangleBear
Copy link

TriangleBear commented Jan 21, 2025

I believe the random mod is rolling a dice whenever it is displaying the circles thus pushing the circles off screen regardless the position.

I have read the code a bit and the problem might steam to HitObject, it doesn't have a check to ensure that the HitObjects are inside the playfield.

Please correct me if I'm wrong.

@smoogipoo
Copy link
Contributor

If there is an issue, it's solely with OsuModRandom. Looks like it may not be considering the stacked position.

@TriangleBear
Copy link

TriangleBear commented Jan 24, 2025

Is the 'DistanceFromPrevious' or any offset change overriding the boundaries of the playfield and starting the stack in unreachable areas?
This also brings into question the positioning of the stack, if the position is based on the center of the whole stack or on the position of the first beat.
If the position is based on the center of the stack, it could be within playfield but the starting beat is outside.
I could try to implement a limit to the position change based on the playfield and if I can find where the data of the dimensions of the whole stack, if it is implemented as previously assumed.

But personally, that is still only a conjecture or assumption of mine.
Also,
I noticed that the orientation and direction of the stack does not change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants