From 03c0dd39d73977872768d41fed88d33b8a7a219f Mon Sep 17 00:00:00 2001 From: Volker Scheuber Date: Wed, 19 Jun 2024 22:39:39 -0500 Subject: [PATCH 1/2] update binary nodes version to 20 --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 35db94f0c..b8f16a1f6 100644 --- a/package.json +++ b/package.json @@ -37,7 +37,7 @@ "build": "npm run build:binary", "build:only": "npx tsup && npx tsc", "build:binary": "npm run build:only && npm run dist-pkg", - "dist-pkg": "pkg -C Gzip -t node18 --config package.json -o frodo dist/app.cjs", + "dist-pkg": "pkg -C Gzip -t node20 --config package.json -o frodo dist/app.cjs", "link": "npm link ../frodo-lib", "dev": "npx tsup --watch src" }, From e2ec3393e67ffb7dc059d1c4c10b27c0fd16e722 Mon Sep 17 00:00:00 2001 From: Volker Scheuber Date: Wed, 19 Jun 2024 22:57:36 -0500 Subject: [PATCH 2/2] update build node version to 18, update package-lock.json, audit dev dependencies, add node 22 and drop node 16 from test matrix, update npm-publish action to v3 --- .github/workflows/pipeline.yml | 25 ++++++++++++++----------- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/.github/workflows/pipeline.yml b/.github/workflows/pipeline.yml index 1f795d01a..78bf8405b 100644 --- a/.github/workflows/pipeline.yml +++ b/.github/workflows/pipeline.yml @@ -59,6 +59,9 @@ jobs: env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + - name: Update package-log.json + run: npm i --package-lock-only + - name: 'Version From Tag' id: version-from-tag run: echo "version=$(echo '${{ steps.version-bump.outputs.newTag }}' | sed 's/v//')" >> "$GITHUB_OUTPUT" @@ -74,7 +77,7 @@ jobs: run: npx tsc - name: Security Audit - run: npm audit --omit=dev --audit-level high + run: npm audit --audit-level high - uses: actions/upload-artifact@v4 with: @@ -89,17 +92,17 @@ jobs: newVersion: ${{ steps.version-from-tag.outputs.version }} preRelease: ${{ contains(steps.version-bump.outputs.newTag, '-') }} - smoke-tests: - name: 'Smoke Tests' + test: + name: 'Test' needs: build # You must use a Linux environment when using service containers or container jobs runs-on: ubuntu-latest strategy: matrix: - node-version: [20, 18, 16] + node-version: [22, 20, 18] # See supported Node.js release schedule at https://nodejs.org/en/about/releases/ - # Service containers to run with `smoke-tests` + # Service containers to run with `test` services: # Label used to access the service container squid: @@ -258,7 +261,7 @@ jobs: - name: Pre-Release if: ${{ fromJSON(needs.build.outputs.preRelease) }} - uses: JS-DevTools/npm-publish@v1 + uses: JS-DevTools/npm-publish@v3 with: access: public tag: 'next' @@ -266,7 +269,7 @@ jobs: - name: Release if: ${{ ! fromJSON(needs.build.outputs.preRelease) }} - uses: JS-DevTools/npm-publish@v1 + uses: JS-DevTools/npm-publish@v3 with: access: public token: ${{ secrets.NPM_ACCESS_TOKEN }} @@ -310,7 +313,7 @@ jobs: macos-binary-release: # don't run on PRs, since secrets are not available if: github.event_name != 'pull_request' - needs: [build, smoke-tests] + needs: [build, test] runs-on: macos-latest timeout-minutes: 15 steps: @@ -387,7 +390,7 @@ jobs: linux-binary-release: # run on PRs for e2e testing binary builds as linux builds do not require secrets. - needs: [build, smoke-tests] + needs: [build, test] runs-on: ubuntu-latest steps: - uses: actions/download-artifact@v4 @@ -425,7 +428,7 @@ jobs: linux-arm64-binary-release: # don't run on PRs to speed up the checks if: github.event_name != 'pull_request' - needs: [build, smoke-tests] + needs: [build, test] runs-on: self-hosted steps: - uses: actions/download-artifact@v4 @@ -464,7 +467,7 @@ jobs: windows-binary-release: # don't run on PRs to speed up the checks if: github.event_name != 'pull_request' - needs: [build, smoke-tests] + needs: [build, test] runs-on: windows-latest steps: - uses: actions/download-artifact@v4