Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] History fails with Snapshot including later-deleted item #4770

Open
2 tasks
cielf opened this issue Nov 10, 2024 · 5 comments · May be fixed by #4876
Open
2 tasks

[Bug] History fails with Snapshot including later-deleted item #4770

cielf opened this issue Nov 10, 2024 · 5 comments · May be fixed by #4876
Assignees
@dorner
Labels
core team Groomed but likely needs expert knowledge stale

Comments

@cielf
Copy link
Collaborator

cielf commented Nov 10, 2024

Summary

If an item existed at the time of the snapshot, but has since been deleted, you can't show that organizations History for a date range including the Snapshot.

Why fix?

Problem exists in the wild, and makes the history less useful. Could also be a problem when we do future Snapshots.

Details

See human-essentials-support discussion starting at November 4, 2024, 4:36pm for an example. Suggest this is a quick fix for @dorner..

Criteria for Completion

  • deleted item does not cause History to fail
  • tests to demonstrate
@github-actions GitHub Actions
Copy link
Contributor

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

@github-actions github-actions bot added the stale label Dec 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

Automatically unassigned after 7 days of inactivity.

@cielf cielf added core team Groomed but likely needs expert knowledge and removed stale labels Dec 19, 2024
@cielf
Copy link
Collaborator Author

cielf commented Dec 19, 2024

Assigning this back to @dorner, as still the best choice.

dorner added a commit that referenced this issue Dec 20, 2024
@dorner
#4770: Don't crash on deleted item for event history
3f48d10
@dorner dorner linked a pull request Dec 20, 2024 that will close this issue
Open
@github-actions GitHub Actions
Copy link
Contributor

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

@github-actions github-actions bot added the stale label Jan 19, 2025
@github-actions GitHub Actions
Copy link
Contributor

Automatically unassigned after 7 days of inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dorner dorner

Labels
core team Groomed but likely needs expert knowledge stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#4770: Don't crash on deleted item for event history rubyforgood/human-essentials
2 participants
@dorner @cielf